[MAINTENANCE] Simplify logic around data context ID creation

[cdkini]

Legacy behavior here has depended on the expectations store with some pretty convoluted logic

• Description of PR changes above includes a link to an existing GitHub issue
• PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
• Code is linted - run invoke lint (uses ruff format + ruff check)
• Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

[netlify]

✅ Deploy Preview for niobium-lead-7998 canceled.

Name	Link
🔨 Latest commit	b3c9c56
🔍 Latest deploy log	https://app.netlify.com/sites/niobium-lead-7998/deploys/66edb4368422670008091067

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
27821	2	27819	5010

View the top 2 failed tests by shortest run time

tests.datasource.fluent.test_viral_snippets test_file_context_add_and_save_fluent_datasource

Stack Traces | 0.204s run time

file_dc_config_dir_init = PosixPath('.../pytest-0/test_file_context_add_and_save0/gx')
fluent_only_config = GxConfig(fluent_datasources=[PostgresDatasource(type='postgres', name='my_pg_ds', id=UUID('dae0accb-fec0-410b-9baa-dd7...0, multiindex_hierarchies=False, mode='xmla')], workspace=None, dataset=UUID('0993ddd1-f01d-4c8f-a64e-9c4e5b8905e8'))])
sqlite_database_path = PosixPath('.../taxi_yellow_tripdata_samples/sqlite/yellow_tripdata.db')

    @pytest.mark.filesystem
    def test_file_context_add_and_save_fluent_datasource(
        file_dc_config_dir_init: pathlib.Path,
        fluent_only_config: GxConfig,
        sqlite_database_path: pathlib.Path,
    ):
        datasource_name = "save_ds_test"
        config_file = file_dc_config_dir_init / FileDataContext.GX_YML
    
        initial_yaml = config_file.read_text()
        assert datasource_name not in initial_yaml
    
        context: FileDataContext = get_context(context_root_dir=config_file.parent, cloud_mode=False)
    
        ds = context.data_sources.add_sqlite(
            name=datasource_name, connection_string=f"sqlite:///{sqlite_database_path}"
        )
    
        final_yaml = config_file.read_text()
        diff = difflib.ndiff(initial_yaml.splitlines(), final_yaml.splitlines())
    
        print("\n".join(diff))
    
        assert datasource_name == ds.name
        assert datasource_name in final_yaml
        # ensure comments preserved
>       assert "# Welcome to Great Expectations!" in final_yaml
E       AssertionError: assert '# Welcome to Great Expectations!' in 'config_version: 4.0\nconfig_variables_file_path: uncommitted/config_variables.yml\nplugins_directory: plugins/\nstores:\n  expectations_store:\n    class_name: ExpectationsStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: expectations/\n  validation_results_store:\n    class_name: ValidationResultsStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: uncommitted/validations/\n  checkpoint_store:\n    class_name: CheckpointStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      suppress_store_backend_id: true\n      base_directory: checkpoints/\n  validation_definition_store:\n    class_name: ValidationDefinitionStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: validation_definitions/\nexpectations_store_name: expectations_store\nvalidation_results_store_name: validation_results_store\ncheckpoint_store_name: checkpoint_store\ndata_docs_sites:\n  local_site:\n    class_name: SiteBuilder\n    show_how_to_buttons: true\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: uncommitted/data_docs/local_site/\n    site_index_builder:\n      class_name: DefaultSiteIndexBuilder\nanalytics_enabled: true\ndata_context_id: 37c7f6e4-60f0-4411-b0a0-38f236a05c2d\nfluent_datasources:\n  save_ds_test:\n    type: sqlite\n    id: 33b2db74-b0e6-44ca-8109-1040538ca2c6\n    connection_string: \n      sqlite:///.../taxi_yellow_tripdata_samples/sqlite/yellow_tripdata.db\n'

.../datasource/fluent/test_viral_snippets.py:143: AssertionError

tests.datasource.fluent.test_viral_snippets test_file_context_add_and_save_fluent_datasource

Stack Traces | 0.248s run time

file_dc_config_dir_init = PosixPath('.../pytest-0/test_file_context_add_and_save0/gx')
fluent_only_config = GxConfig(fluent_datasources=[PostgresDatasource(type='postgres', name='my_pg_ds', id=UUID('dae0accb-fec0-410b-9baa-dd7...0, multiindex_hierarchies=False, mode='xmla')], workspace=None, dataset=UUID('0993ddd1-f01d-4c8f-a64e-9c4e5b8905e8'))])
sqlite_database_path = PosixPath('.../taxi_yellow_tripdata_samples/sqlite/yellow_tripdata.db')

    @pytest.mark.filesystem
    def test_file_context_add_and_save_fluent_datasource(
        file_dc_config_dir_init: pathlib.Path,
        fluent_only_config: GxConfig,
        sqlite_database_path: pathlib.Path,
    ):
        datasource_name = "save_ds_test"
        config_file = file_dc_config_dir_init / FileDataContext.GX_YML
    
        initial_yaml = config_file.read_text()
        assert datasource_name not in initial_yaml
    
        context: FileDataContext = get_context(context_root_dir=config_file.parent, cloud_mode=False)
    
        ds = context.data_sources.add_sqlite(
            name=datasource_name, connection_string=f"sqlite:///{sqlite_database_path}"
        )
    
        final_yaml = config_file.read_text()
        diff = difflib.ndiff(initial_yaml.splitlines(), final_yaml.splitlines())
    
        print("\n".join(diff))
    
        assert datasource_name == ds.name
        assert datasource_name in final_yaml
        # ensure comments preserved
>       assert "# Welcome to Great Expectations!" in final_yaml
E       AssertionError: assert '# Welcome to Great Expectations!' in 'config_version: 4.0\nconfig_variables_file_path: uncommitted/config_variables.yml\nplugins_directory: plugins/\nstores:\n  expectations_store:\n    class_name: ExpectationsStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: expectations/\n  validation_results_store:\n    class_name: ValidationResultsStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: uncommitted/validations/\n  checkpoint_store:\n    class_name: CheckpointStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      suppress_store_backend_id: true\n      base_directory: checkpoints/\n  validation_definition_store:\n    class_name: ValidationDefinitionStore\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: validation_definitions/\nexpectations_store_name: expectations_store\nvalidation_results_store_name: validation_results_store\ncheckpoint_store_name: checkpoint_store\ndata_docs_sites:\n  local_site:\n    class_name: SiteBuilder\n    show_how_to_buttons: true\n    store_backend:\n      class_name: TupleFilesystemStoreBackend\n      base_directory: uncommitted/data_docs/local_site/\n    site_index_builder:\n      class_name: DefaultSiteIndexBuilder\nanalytics_enabled: true\ndata_context_id: c16cd4b8-63ff-4ecb-baa6-68d119cd9808\nfluent_datasources:\n  save_ds_test:\n    type: sqlite\n    id: 737649f5-5c7b-4b42-b30a-9c3b8cf3f709\n    connection_string: \n      sqlite:///.../taxi_yellow_tripdata_samples/sqlite/yellow_tripdata.db\n'

.../datasource/fluent/test_viral_snippets.py:143: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

[cdkini]

We no longer have this conditional logic based on expectations store - we don't need these tests