Adding different types of towers and masts #2671
Conversation
|
I think the mast and lattice tower icon are not really recognizable at normal resolution, for mast i preferred the suggestions by @BushmanK in #2556 (comment) (the double guy lines version probably requires some tuning though). I have doubts the starting zoom level logic you suggest makes sense. Starting tall masts/towers one zoom level earlier and small ones one later makes some sense but stretching this across five zoom levels requires demonstrating that this has some specific advantages i think. And in case of towers mapped as building polygons with both building tag and man_made=tower rendering both the building and an icon would be irritating since this will possibly look like there is a tower on the building. |
|
About the icons. Those are the only once I got from @BushmanK to test. If there will be different set present I have no objections to change them for the better types. Levels can always change. My are just a proposition which can change if some agreement there is made for different level. Height there plays important role as it is obvious that tower with greater height is visible from further distance therefore should appear sooner. If tower is also tagged as building than that to me seems as bad tagging which should be fixed on the map and only reason someone tagged it like was that it was the closest tag possible to have them appear on the map. |
|
Please be as specific as possible when discussing, so I could make the changes to the code. @wmyrda - are you capable of creating proper patches? It would be much easier for me to just apply them here instead of tracking someone else's code. |
|
@wmyrda Since you are now capable of making your own PRs, I suggest that you recreate this one by yourself too. It will allow you to make changes any time you want instead of waiting for me to apply patches. Rendering examples is needed for all the tower types you propose. |
|
What is the status of this proposal? |
|
I plan to take over this code after some easier problems are resolved. |
kocio-pl
changed the title
kocio-pl
force-pushed
the
towers-wmyrda
branch
from
8d434cb to
30c445c
Compare
|
This is much anticipated PR - and rightly so, because towers and masts are visible from a long distance. Some icons are redundant (the same image with a different name), but that can be not touched for now until we agree which ones we want to use. For now just a test rendering with linked examples (they might be useful for testing further changes): man_made=mast man_made=tower
|
|
Other possible shapes to render:
|
|
This will be fantastic when you roll it out. It looks pretty good to my amateur eyes |
|
Code update, new types added and name labels fixed so they appear only when the object is shown. |
|
Currently I just cut down the initial zoom level for labels, so it always starts with the z17 (towers) and z18 (masts), because these are the zoom levels where the towers/masts are rendered even in the worst case. Do you think it makes sense to render labels as soon as the objects are visible (correlated with |
|
I like this observation tower shape more: |
kocio-pl
changed the title
|
The code is in mergeable shape now. Done the code cleaning and fixing height selection to be numeric. I also think that names should be not revealed too early to not eclipse other objects names - it's enough to see the shape of a tower/mast early on if it's big enough (see the examples below). Examples of really big objects on initial zoom level (actually both are telecommunication masts, but that's the current tagging): |
|
Lattice towers should be taller to be easier recognized as towers (similar to Eiffel Tower proportions). It seems that both generic and lattice towers were made smaller as a fix for communication waves (so the top of the tower is in the center of the rings) and generic tower without them is taller, so it also makes perfect sense design-wise.
|
|
BTW - after fixing tagging of the Eiffel Tower it looks not too strong, even though it's the center of a big city, and introducing this icon fixes problem on z15: z13 z14 z15 After |
|
I've made lattice towers as high as the 14 px allow, for it to be easily seen. |
|
I don't think we should really try to differentiate basing on materials, having different shapes is enough in my opinion. |
|
dome v2 might be somewhat misleading to the viewer in me eyes. tower:construction=dome is also not very common with 129x. |
|
I miss |
|
Of course, it's still not being added to the code. I try to collect the ideas how do we want to render few other masts/towers and then make part 2 of this PR pretty soon, not adding them case by case. |
|
|
|
sent from a phone
On 24. Mar 2018, at 07:26, geozeisig ***@***.***> wrote:
tower:construction=dish merged with man_made=telescope
We should think about an icon for man_made=telescope because that describes the feature better.
a telescope doesn’t have to have a dish, it is simply an instrument to look into the distance
|
Where a lighthouse, light mostly horizontal, a lighting tower, light, say, 45 degree to the surface. I think, icon lighting look to much at communication icon. Could be more of a difference? |
|
I'm satisfied with the result, but feel free to redesign it if you want. |
|
@dieterdreist A telescope can be optical but there is also radio telescope (see Wiki. Otherwise the tagging would be wrong here ? We do not have a good wiki page for dish yet. On the other hand, a dish is not a real tower. |
|
There is a handy tag called location - I'd like to use it for example for hiding communication masts mounted on the building, since their height is counted with the whole building, which might be weird and misleading, because they are not that important and visible, like here: https://www.openstreetmap.org/node/2471572605#map=14/52.2543/20.9838 Interesting value seems to be |
|
The height of the building roof should be mentioned in |
|
Is it documented somewhere? I don't remember seeing it on tower/mast pages. |
I could not find it either, seems logical to me. Therefor "should be". Watching 3D buildings. When a height is mentioned for the antenna/transponder. So the mast/ tower should get a min_height but also this transponder a min_height. Side of building. A mast or is it a pole for some communication:mobile_phone? There must be a tag, that says not on ground level. As always in OSM there multiple tags that indicate it. |
|
Thanks for the research. I think that min_height for masts and towers should be discussed on Tagging list and when accepted (I don't expect any problems with this - it's just natural consequence of tagging "brutto" height that it should be able to calculate "netto" height) documented on wiki. Could you do this, please? But since it's not yet done and requires calculating in SQL, I prefer to start with simpler approach and use location. It won't hurt if we skip rendering few masts mounted on roofs but it may clutter urban areas when mapped in detail if we don't know exact height of the building for example, but it's clear that these are not standalone masts. |
|
2018-03-26 16:28 GMT+02:00 AllroadsNL <[email protected]>:
Is it documented somewhere?
I could not find it either, seems logical to me. Therefor "should be".
Watching 3D buildings.
When a height is mentioned for the antenna/transponder.
Often the extern data gives only height for mobil_phone
<https://wiki.openstreetmap.org/wiki/Key:communication:mobile_phone>
mounted height, not total length of tower/mast, there often multiple on the
mast/tower. (Not good described, looks like multiple traffic_sign problem,
which method to use)
So the mast/ tower should get a min_height but also this transponder a
min_height.
a min_height for mast or towers does not make sense IMHO (unless they are
on top of something, but not if they are on the ground). For antennas and
transponders that are attached to another structure it is different of
course.
pitfall:
But when min_height is used on a building node, it means also that the
building get a strange shape.
min height means the height of something is not what is indicated in the
height tag but actual height = height - min_height with height + ele =
absolute height
|
|
2018-03-26 12:50 GMT+02:00 kocio-pl <[email protected]>:
There is a handy tag called location
<https://wiki.openstreetmap.org/wiki/Key:location> - I'd like to use it
for example for hiding communication masts mounted on the building, since
their height is counted with the whole building, which might be weird and
misleading, because they are not that important and visible, like here:
https://www.openstreetmap.org/node/2471572605#map=14/52.2543/20.9838
Interesting value seems to be location=rooftop ("Located on top of a
building that is used for something else."). I'm not sure about
location=roof ("Used where a feature is mounted on the roof of a
building."), because this might be a legitimate mast located on a small
building under it, but I suspect it's safer to hide them too just in case.
there is also location=roof I would see it as a synonym of rooftop and
would not require "used for something else" for this tag).
|
Optical telescopes are almost never outdoors. They are operated under a dome, tagged with For |
|
It occurs to me that dome v2 image is very similar to the weather radars used here in Australia. It would useful for describing those at the very least |
|
What is the tagging used for them? |
|
It looks to me that it's just a dome type construction, the whole station should be tagged as: https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dmonitoring_station See this picture: https://wiki.openstreetmap.org/wiki/File:Mildura_Airport_Weatherstation.jpg |
|
I think this one should be rendered the same as https://wiki.openstreetmap.org/wiki/Tag:tower:type%3Dwatchtower |
|
Do you mean Tower observation.svg? |
It's a higgledy-piggledy mess unfortunately. A lot of them aren't (yet) tagged at all - something i'm working on now.
|
|
Scrub that. They're tagged |
|
I have created new PR with the proposed changes, please discuss all the things related to vertical structures there. |
Resolves #2556
Resolves #2791
Resolves #1225
Resolves #2024
This code is based on @wmyrda patch. It renders, but each type of tower/mast needs to be tested if it really appears on the map, so for now it's a work in progress.