-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish different memorial types #3088
Comments
See also proposed rendering of towers (and masts) by @BushmanK and @wmyrda. The problem is however smaller, since they use different color (man-made gray). |
Gist links:
|
memorial:type=stolperstein is much more common than memorial=stolperstein. If now memorial=stolperstein is to be rendered we must clarify before how we can make a mass edith. |
I was reporting the problem of stolperstein and blue_plaque definitions once on Tagging, but got no response. They need some unification or just cleaning, but we can decide on our own what we want to render and how, of course. |
Thanks for working on this. To be honest, I think this proposal goes into too much detail, and I wouldnt be happy to add so much new icons for relatively similar objects. |
Ok, I'm taking care of this thread. |
@Tomasz-W in reference to your comment of 27/02, there is 3 different icons to compare: Currently, obelisks are rendered in a similar way than |
It's not similar way, it's the same icon. I didn't know about man_made=obelisk tag, I though there is "memorial=obelisk" subtag (as it is kind of memorial), but Wiki says that man_made=obelist is the proper tag.
I think a new obelisk icon should be used for |
Indeed, there is 3 different tags for the same feature and the wiki does not provide any difference between memorial and man_made. I would suggest to propose a new icon for monument with a different shape to better differentiate from obelisk. Both present a vertical shape and I'm not sure that people will understand the difference. We can also leave the current one to obelisk which remains different to man_made=tower. Additionally, I'm wondering about the zoom level. Currently:
Should I change something or leave as it ? |
Any other comments about obelisk/ monument icons? As always, I'm open for icon ideas. @kocio-pl Can you review the topic and share your thoughts? You know the proper zoom levels for certain features the best :) |
IMHO we should render only man_made=obelisk. It is the first of these tags
and the one with the most usage. The other tags don't have different
semantics / meaning so supporting them will only lead to tag fragmentation.
|
I can test if you submit an icon. Otherwise, I thought about an equestrian statue (example) but it's probably too much detailled. |
If it helps anyone, feel free to draw inspiration from the icons at https://map.atownsend.org.uk/maps/map/map.html#zoom=17&lat=-25.005818&lon=135.17675 and e.g. https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/blob/master/symbols/memorial_bench.png ). |
@jragusa Can you test it? Gist link: https://gist.github.com/Tomasz-W/9ad756936dab43da9383c6586551e2e0 PS. As there is no special tag for equestrian statues, I think we don't need to worry about them :) See: |
et voilà: @Tomasz-W I meant using an equestrian statue as generic icon for monument. |
Currently,
|
For memorial benches I vote for 'left' version. I also would like to see a test rendering of PS. @jragusa Did you download my icons after 11.06? I was pixel-aligning them and meanwhile I've updated the files in Gist links. |
I don't remember but I did the first commit on 12/06 so, in case of, I will reupload your icons |
Unfortunately, nobody has responded to this. I'm still not convinced how much we're gaining from rendering different monument types. |
Well, for me these are 2 issues: more icons and more detailed rendering rules. More icons are good because they are representing what people see on the ground more accurately and more detailed rules are good to avoid clutter (in this case something I started with #2689, which was the most severe problem). This is related to the freedom of categorizing and tagging. We try to render tags, because it's simpler technically, but I believe we should render things people see. It's hard to tell if something is forest or woods, so we show the trees, which is what people see (poor tagging definitions is secondary here). It's easy to tell if the memorial is statue or obelisk, so they should be rendered differently (if we have proper icons, not by all means). |
The risk of adding more icons, though, is that map users will need to spend more effort in order to ‘learn’ the meaning if all symbols. |
But we design icons depicting things more accurately, so in my opinion it will make it easier to recognize than currently, not harder. |
There should be a link on the main site to a list of the icons and their meanings like there is for the road type key. |
@Adamant36 See #1928 |
(previous comment moved to openstreetmap/openstreetmap-website#1307 (comment) where it makes more sense) |
I like https://wiki.openstreetmap.org/wiki/Standard_tile_layer/Key more, but that's a problem that it's big (and needs updates), while OSM.org website has some short legend, but not suited for such a rich style, and doesn't have even link to this page. |
@SomeoneElseOSM @kocio-pl |
|
|
@jragusa it's not |
@Tomasz-W sorry it's a typo error. It's actually a |
@jragusa Are you willing to make a PR for this issue? |
Sorry for the long pause, I had to finish corrections on a manuscript. I'm working on it. |
If someone has an idea for better non-statue artwork icon, give me an info. There are some of my experiments based on example outdoor artworks: https://www.google.pl/search?client=opera&hs=H4C&biw=1920&bih=981&tbm=isch&sa=1&ei=riCBW_KcKsOzswGE2ofgBA&q=outdoor+sculpture&oq=outdoor+sculpture&gs_l=img.3...84912.88116.0.88235.16.12.0.0.0.0.117.690.4j3.7.0....0...1c.1.64.img..11.5.477...0j0i7i30k1j0i8i7i30k1j0i67k1.0.Kibj5gIil0E#imgrc=_ |
I was thinking about something like https://abstractmetaldesign.com/wp-content/uploads/2017/04/Abstract-Metal-Design411.jpg so as second proposition looks closest to it I am all for it. |
@wmyrda Please see #3356 (comment) |
Currently we render all of memorials by just two icons, which are not every time match real object shape well. I would like to propose more icons to distinguich certain types of memorials.
https://wiki.openstreetmap.org/wiki/Key:memorial
My proposition:
('memorial' icon)
('plaque' icon)
('plaque' icon)
(new)
(new)
('memorial' icon)
('plaque' icon)
(new)
(new)
For comparsion:
(obelisk icon proposal)
(historic=monument current icon)
(statue icon proposal)
(tourism=artwork current icon)
Potentially. we could think about change tourism=artwork icon. Some fast-made ideas (lower block set to 50% transparency):
The text was updated successfully, but these errors were encountered: