Render remaining tourism_information features

[jragusa]

Fixes #304
Fixes #324
Fixes #1978

Changes proposed in this pull request:
This PR completes #3198 by adding rendering of audioguide, board, map, office, tactile_map, tactile_model and terminal

Test rendering with links to the example places:

information=audioguide
https://www.openstreetmap.org/node/3066454413

information=board
https://www.openstreetmap.org/node/2857924837
script-version

i-version

information=map
https://www.openstreetmap.org/node/4939116583

information=office
https://www.openstreetmap.org/way/130442457
z=17

z=19

with other brown amenities
https://www.openstreetmap.org/node/5537445277

information=tactile_map
https://www.openstreetmap.org/node/3571444993

[jragusa]

Some remarks:

• tourism=officeis displayed earlier (z=17), is it ok ?
• I don't have tactile_model in my data.osm but I can find out elsewhere if needed as well as audioguide with a name.
• I moved all related icons in a specific folder tourism.
• Sometimes map icon is displayed above a track or a path which may reduce the readability of the icon
• Finally, I would also proposed to render guideposts at z=18 (following @Tomasz-W, because there is not so much features in countryside or in mountain area and they are important landmarks.

[kocio-pl]

Thanks! I plan to review and test it later.

1. I think tourism office is like other offices and shops, so z17+ is perfect for me.

2. You can export small areas in OSM format just using the website:

https://www.openstreetmap.org/export

Import them using the same osm2pgsql command as for PBF files.

3. Unfortunately guideposts are very popular part of the city information systems, so I would not elevate their rendering level. If some tags will be invented to help make the difference between outdoor and city usage, I would be happy to render the former type earlier.

[dieterdreist]

sent from a phone

On 26. May 2018, at 15:16, kocio-pl ***@***.***> wrote: I think tourism office is like other offices and shops, so z17+ is perfect for me.

for a tourism oriented map, tourist offices are at least 2 zoom levels more important than other offices (if they even show the latter). We are a ‘general’ map, whatever this means, but still I can bring up good arguments why tourist information offices could be more prominent than other shops and offices: e.g. they are by large more interesting for a wider audience.

[kocio-pl]

Touristic offices are usually located in the urban areas, so I would not like to see them earlier, because of problems with city items clutter.

When they are located near some outdoor attractions, they are probably similar in importance with gift shops or ticket shops, so still nothing to be shown earlier for me.

[Tomasz-W]

As brown is heavily loaded by gastronomic, historic and other tags, and information=* objects are not so important, I would like to see test renderings of them in man-made grey. We could also consider to render most of these icons in grey, but left generic and information=office icons in brown.

@nebulon42 related to #3198

[Tomasz-W]

@jragusa please add information=terminal icon:

Gist link: https://gist.github.com/Tomasz-W/e8cf9ed9647381ab59370a6ce3a8f312

[kocio-pl]

I hope you will make a rendering test for man_made gray?

[jragusa]

Sorry, I was too tired last evening to prepare the renderings. Here they are with
man-made grey colour:

information=audioguide
https://www.openstreetmap.org/node/1412978425

information=board
https://www.openstreetmap.org/node/2857924837

information=guidepost
https://www.openstreetmap.org/#map=19/46.21323/6.46334

information=map
https://www.openstreetmap.org/node/4939116583

information=office and information=terminal
https://www.openstreetmap.org/node/2473539607
https://www.openstreetmap.org/way/380875391

[Tomasz-W]

Now I'm sure that most of these icons should be grey, but I still thinking what to do with information=office and generic "i" icon. My proposition:

• information=office -> brown or office-blue (it's something more complicated than a free standing object)
• generic icon -> grey

[dieterdreist]

2018-05-28 11:22 GMT+02:00 Tomasz Wójcik <[email protected]>:

Now I'm sure that most of these icons should be grey, but I still thinking what to do with information=office and generic "i" icon. My proposition: - information=office -> brown or office-blue (it's something more complicated than a free standing object) - generic icon -> grey

offices in OSM are mostly about places you can't just step in (as opposed to shops). information=office could either be amenity color or shop colour, office colour doesn't seem to fit well.

[kocio-pl]

generic icon -> grey

👍

offices in OSM are mostly about places you can't just step in (as opposed to shops).

I think the difference is not that clear, and you can walk in some of them, but you just won't directly buy things most of the time. I think brown is good, since the main function of information office is getting informations, not buying (though one can buy maps or gifts also).

[Tomasz-W]

@jragusa
summary:

• audioguide, board, map ,tactile_map, tactile_model, terminal, guidepost -> grey
• generic icon -> grey
• office - > brown

[jragusa]

following last recommendations:
https://www.openstreetmap.org/#map=19/46.26756/6.84134

[jragusa]

@kocio-pl Do you want I squash commits into one for merging ?

[kocio-pl]

I always prefer it, but that's optional. It's just my more relaxed time now, but I can test and merge it in the upcoming days.

[jragusa]

ok, it's done

[Tomasz-W]

@jragusa As this PR is ready to merge, are you interested in write code for simillar issue of #3088 ? It's even less complicated, because there is only one colour for all icons (memorial-brown).

[kocio-pl]

You need to exclude all the cases that should be rendered later, like audioguide or map, because otherwise they will be rendered with standard icon from z17 and as a specific icon from z19.

[jragusa]

Ok I thought that it should be the correct behaviour as they currently appear at z17 with the generic icon. So you prefer that only office is displayed at z17 ?

[jragusa]

@kocio-pl if last commits are ok for you I can squash them

[kocio-pl]

Thanks, that looks good! I will check it soon, I hope.

[kocio-pl]

Ok, this all seems to be working good, you can squash it and I'm ready to merge it.

[jragusa]

Done

I also homogenised the code of label with icon. It's now more efficient and clean

[kocio-pl]

Please don't add the foreign code changes like:

(tags->'office') IS NOT NULL

It needs a separate PR.

[jragusa]

I squashed one commit in excess. It's ok now

[kocio-pl]

Thanks for you work and updates, sorry for such long delay with re-testing.

[jragusa]

No worries, it's summer time :)

[Tomasz-W]

@jragusa Hey, I've found some problems with icon + name rendering of some of information=* subtypes. While eg. map or generic icon rendering looks ok, names of information=board or information=terminal are on the down left side of the icon, examples:
https://www.openstreetmap.org/node/4935294691
https://www.openstreetmap.org/node/5679218763
https://www.openstreetmap.org/node/4215316042
Can you take a look on this and try to fix it?

[jragusa]

Indeed, some artefacts remain in the svg files (filled in grey):

That's concern audioguide, board and terminal. I will make a PR to fix this bug.

[Tomasz-W]

I don't know how it happened, but I noticed that there is board.svg icon used for information=tactile_model when it's actualy a horizontal 3D map in most cases, so it's surely closer to a map than a board and shoud be rendered by map.svg icon. @jragusa Can you make a PR fixing it?

Example: https://www.openstreetmap.org/node/4362875819