[v17] WebUI MFA types refactor #49974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
the
no-changelog
avatus
approved these changes
Dec 9, 2024
rosstimothy
approved these changes
Dec 9, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark and
kiosion
ryanclark
reviewed
Dec 10, 2024
| @@ -62,7 +62,7 @@ | |||
| "prettier": "^3.3.3", | |||
| "react-select-event": "^5.5.1", | |||
| "storybook": "^8.3.4", | |||
| "typescript": "^5.6.2", | |||
| "typescript": "^5.7.2", | |||
There was a problem hiding this comment.
Why this upgrade in a backport?
There was a problem hiding this comment.
The version update was necessary to fix the linting issue seen here - https://github.com/gravitational/teleport/actions/runs/12247136930/job/34164410155
There was a problem hiding this comment.
The issue seems to be that #49613 hasn't been backported, but the typescript update is the only thing this PR needs. WDYT?
There was a problem hiding this comment.
Ah okay, fair enough. I don't think it's worth opening another PR to do this
Joerger
force-pushed
the
bot/backport-49678-branch/v17
branch
from
2b12ec1 to
62edcd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49678 to branch/v17