[v17] update ArrayBuffer to ArrayBufferLike #50094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
flyinghermit
added
the
no-changelog
github-actions
bot
requested review from
avatus,
Joerger,
rosstimothy and
ryanclark
rudream
approved these changes
Dec 11, 2024
ryanclark
approved these changes
Dec 11, 2024
public-teleport-github-review-bot
bot
removed request for
avatus,
Joerger and
rosstimothy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49974 updates typescript version
5.6.2to5.7.2. This version is not compatible with the arraybuffer (or "arraybufferlike") data as generated for the MFA response transport https://github.com/gravitational/teleport.e/blob/master/web/teleport/src/SAMLIdPLogin/SAMLIdPLogin.tsx#L34C8-L39C79.The type error can be seen in this Github action log https://github.com/gravitational/teleport.e/actions/runs/12264912878/job/34269978472?pr=5668#step:8:18
The changes made in this PR is already in master, introduced by #49613.
Manually tested the changes by enforcing per session MFA for SAML IdP and a successful redirect to a service provider.