-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate to aws status dash from integrations list #49847
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
web/packages/teleport/src/Integrations/IntegrationList.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/** | ||
* Teleport | ||
* Copyright (C) 2023 Gravitational, Inc. | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
import { fireEvent, render, screen, userEvent } from 'design/utils/testing'; | ||
|
||
import { Router } from 'react-router'; | ||
|
||
import { createMemoryHistory } from 'history'; | ||
|
||
import { IntegrationList } from 'teleport/Integrations/IntegrationList'; | ||
import { | ||
IntegrationKind, | ||
IntegrationStatusCode, | ||
} from 'teleport/services/integrations'; | ||
|
||
test('integration list shows edit and view action menu for aws-oidc, row click navigates', async () => { | ||
const history = createMemoryHistory(); | ||
history.push = jest.fn(); | ||
|
||
render( | ||
<Router history={history}> | ||
<IntegrationList | ||
list={[ | ||
{ | ||
resourceType: 'integration', | ||
name: 'aws-integration', | ||
kind: IntegrationKind.AwsOidc, | ||
statusCode: IntegrationStatusCode.Running, | ||
spec: { roleArn: '', issuerS3Prefix: '', issuerS3Bucket: '' }, | ||
}, | ||
]} | ||
/> | ||
</Router> | ||
); | ||
|
||
fireEvent.click(screen.getByRole('button', { name: 'Options' })); | ||
expect(screen.getByText('View Status')).toBeInTheDocument(); | ||
expect(screen.getByText('View Status')).toHaveAttribute( | ||
'href', | ||
'/web/integrations/status/aws-oidc/aws-integration' | ||
); | ||
expect(screen.getByText('Edit...')).toBeInTheDocument(); | ||
expect(screen.getByText('Delete...')).toBeInTheDocument(); | ||
|
||
await userEvent.click(screen.getAllByRole('row')[1]); | ||
expect(history.push).toHaveBeenCalledWith( | ||
'/web/integrations/status/aws-oidc/aws-integration' | ||
); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"View Status" seems weird to me. there is a status column right next to it, isn't that viewing the status? If this takes you to the dashboard, would it be better for something like "Go to Dashboard" or "View Dashboard"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posted on design for feedback https://www.figma.com/design/v6GunK50D2VC7w7I2FBDNf?node-id=4848-37322#1059356782
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok keeping "View Status" for now, as this should match the okta UX. I have a note to return to this language at the end and see if it makes sense for the integrations.
What I was missing is that in matching the Okta UX this row should navigate on click. Re-requesting reviews with update 069179c.