Navigate to aws status dash from integrations list #49847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
michellescripts
added
the
no-changelog
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
2 times, most recently
from
7280141 to
20d8d78
Compare
michellescripts
force-pushed
the
michelle/ec2
branch
3 times, most recently
from
f1831bf to
2dd2dcb
Compare
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
20d8d78 to
3e5c84f
Compare
michellescripts
force-pushed
the
michelle/ec2
branch
2 times, most recently
from
102cd2a to
8524c5f
Compare
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
3e5c84f to
d41e609
Compare
avatus
previously approved these changes
Dec 10, 2024
| item.name | ||
| )} | ||
| > | ||
| View Status |
There was a problem hiding this comment.
"View Status" seems weird to me. there is a status column right next to it, isn't that viewing the status? If this takes you to the dashboard, would it be better for something like "Go to Dashboard" or "View Dashboard"?
There was a problem hiding this comment.
Posted on design for feedback https://www.figma.com/design/v6GunK50D2VC7w7I2FBDNf?node-id=4848-37322#1059356782
There was a problem hiding this comment.
Ok keeping "View Status" for now, as this should match the okta UX. I have a note to return to this language at the end and see if it makes sense for the integrations.
What I was missing is that in matching the Okta UX this row should navigate on click. Re-requesting reviews with update 069179c.
gzdunek
previously approved these changes
Dec 11, 2024
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
d41e609 to
069179c
Compare
michellescripts
dismissed stale reviews from gzdunek and avatus
Review commit 069179c
avatus
approved these changes
Dec 12, 2024
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
069179c to
4513534
Compare
gzdunek
approved these changes
Dec 13, 2024
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
4513534 to
144f708
Compare
michellescripts
force-pushed
the
michelle/dashboard-nav
branch
from
144f708 to
db1285e
Compare
michellescripts
added a commit
that referenced
this pull request
Dec 17, 2024
michellescripts
added a commit
that referenced
this pull request
Dec 18, 2024
michellescripts
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a menu item to aws-oidc integrations to "view status." This will navigate users to the aws oidc dashboard.
Closes #49087