Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the tctl notifications command #48829

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Enhance the tctl notifications command #48829

merged 1 commit into from
Nov 13, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Nov 12, 2024

  • Add the ability create notifications with a custom TTL (previously we relied on the server-provided default of 30 days)
  • Add the ability to create notifications with custom labels
  • Add (non-system) labels to the tctl notifications ls output
  • Add the ability to filter by label when listing notifications

Closes #48631

@github-actions github-actions bot added size/sm tctl tctl - Teleport admin tool labels Nov 12, 2024
@zmb3 zmb3 mentioned this pull request Nov 12, 2024
Closed
@aws-amplify-us-west-2 AWS Amplify (us-west-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48829.d3pp5qlev8mo18.amplifyapp.com

@zmb3 zmb3 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 and removed backport/branch/v15 labels Nov 12, 2024
@zmb3 zmb3 requested a review from rosstimothy November 13, 2024 14:33
rosstimothy
rosstimothy approved these changes Nov 13, 2024
View reviewed changes
lib/auth/notifications/notificationsv1/service.go Outdated Show resolved Hide resolved
lib/auth/notifications/notificationsv1/service.go Outdated Show resolved Hide resolved
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from hugoShaka November 13, 2024 15:15
@zmb3 zmb3 added this pull request to the merge queue Nov 13, 2024
@zmb3 zmb3 removed this pull request from the merge queue due to a manual request Nov 13, 2024
@zmb3
Enhance the tctl notifications command
7dd11c1 
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
@zmb3 zmb3 force-pushed the zmb3/notifications-for-jim branch from 3472fff to 7dd11c1 Compare November 13, 2024 17:05
@zmb3 zmb3 enabled auto-merge November 13, 2024 17:05
@zmb3 zmb3 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 2298901 Nov 13, 2024
43 checks passed
@zmb3 zmb3 deleted the zmb3/notifications-for-jim branch November 13, 2024 17:44
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Create PR

This was referenced Nov 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudream rudream rudream approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@sclevine sclevine sclevine approved these changes

Assignees
No one assigned
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm tctl tctl - Teleport admin tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

notifications: add ability to create with ttl and custom labels
5 participants
@zmb3 @sclevine @gabrielcorado @rosstimothy @rudream