Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: add ability to create with ttl and custom labels #48631

Closed
rcanderson23 opened this issue Nov 7, 2024 · 5 comments · Fixed by #48829
Closed

notifications: add ability to create with ttl and custom labels #48631

rcanderson23 opened this issue Nov 7, 2024 · 5 comments · Fixed by #48829
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@rcanderson23
Copy link
Contributor

What would you like Teleport to do?

  1. Create notifications with custom ttl: tctl notifications create --title="Title" --content="Content" --ttl=1d
  2. Create notifications with custom label: tctl notifications create --title="Title" --content="Content" --label=owner=bot --label=another=label
  3. Be able to list notifications by label: tctl notifications ls --label=owner=bot

What problem does this solve?

  • Ability to create short or long term alerts with custom TTL.
  • Improve ability to get specific set of metrics

If a workaround exists, please include it.

@rcanderson23 rcanderson23 added the feature-request Used for new features in Teleport, improvements to current should be #enhancements label Nov 7, 2024
@sclevine
Copy link
Member

sclevine commented Nov 7, 2024

Note that for Cloud, we'd like to create notifications with no TTL that we can add/remove using our own automation.

@zmb3
Copy link
Collaborator

zmb3 commented Nov 12, 2024

Note that for Cloud, we'd like to create notifications with no TTL that we can add/remove using our own automation.

Can you get by with just setting a larger TTL than you'll expect you'll ever need? (180d for example)

@sclevine
Copy link
Member

Can you get by with just setting a larger TTL than you'll expect you'll ever need? (180d for example)

We plan to manage notifications declaratively, so this could result in a mismatch between our configuration system (Kubernetes resource spec) and what the user sees after 180 days. That said, if very large values are supported (e.g., 10 years), probably not an issue.

zmb3 added a commit that referenced this issue Nov 12, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
@zmb3
Copy link
Collaborator

zmb3 commented Nov 12, 2024

#48829 should do the trick if you're okay setting a very large TTL. LMK.

@sclevine
Copy link
Member

Thanks, looks great! A few hundred years should do it 🙂

zmb3 added a commit that referenced this issue Nov 13, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
github-actions bot pushed a commit that referenced this issue Nov 13, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
zmb3 added a commit that referenced this issue Nov 13, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
- Add the ability create notifications with a custom TTL
  (previously we relied on the server-provided default of 30 days)
- Add the ability to create notifications with custom labels
- Add (non-system) labels to the `tctl notifications ls` output
- Add the ability to filter by label when listing notifications

Closes #48631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants