cache /find endpoint #48016
Merged
cache /find endpoint #48016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
backport/branch/v14
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
espadolini
reviewed
Oct 28, 2024
hugoShaka
force-pushed
the
hugo/speed-up-find-endpoint
branch
from
10ea777 to
9683a39
Compare
vapopov
approved these changes
Oct 28, 2024
public-teleport-github-review-bot
bot
removed request for
sclevine,
timothyb89 and
rudream
sclevine
approved these changes
Oct 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@hugoShaka See the table below for backport results.
|
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @espadolini 's request: this PR wraps the
/findendpoint with a 10-second function cache to ensure it scales nicely.The per-group/per-agent AU logic should be inserted after the cache lookup.