Implement immediate schedule support for automatic updates #47920
Conversation
hugoShaka
added
the
no-changelog
hugoShaka
force-pushed
the
hugo/initial-proxy-agent-update-implementation
branch
from
24f99fe to
dd79107
Compare
| // AgentVersion defines the version of teleport that agents enrolled into autoupdates should run. | ||
| AgentVersion string `json:"agent_version"` | ||
| // AgentAutoUpdate indicates if the requesting agent should attempt to update now. | ||
| AgentAutoUpdate bool `json:"agent_auto_update"` |
There was a problem hiding this comment.
Noticing that this is inconsistent with the tools_mode field that has the same meaning.
@vapopov The _mode fields were intended for configuration, not for the command sent to clients/agents. Could we change ToolsMode string to ToolsAutoUpdate bool to match this PR?
|
@hugoShaka would it make sense to add the Teleport edition and FIPS compliance status to this PR? |
hugoShaka
force-pushed
the
hugo/initial-proxy-agent-update-implementation
branch
from
0586a36 to
28c3899
Compare
lib/web/apiserver.go
Outdated
| } | ||
|
|
||
| autoUpdateConfig, err := h.cfg.AccessPoint.GetAutoUpdateConfig(r.Context()) |
There was a problem hiding this comment.
This (or the new implementation) should 100% not be in the path for /webapi/find like this, it's bad enough that we are doing any work in the find handler right now (with GetProxySettings and the recent addition of GetAuthPreference) - find is rate-unlimited and it's called far too often by basically every cluster component and client.
Maybe this could be the occasion to finally add a FnCache with a few seconds of TTL for the object about to be returned? Any per-request personalization can then be added with a shallow clone if necessary.
hugoShaka
force-pushed
the
hugo/initial-proxy-agent-update-implementation
branch
from
28c3899 to
b07a437
Compare
public-teleport-github-review-bot
bot
removed request for
ravicious and
kiosion
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This PR adds support for the agent automatic update immediate schedule.
Part of #47126
This PR adds the proxy response for the agent. Currently only the immediate schedule is supported because we don't have the
autoupdate_agent_rolloutreconciler yet.This also fixes an issue introduced in #48016 whwre the wrong context was used in the cached function.