Add Cluster Management page #47899
Merged
Add Cluster Management page #47899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
mcbattirola
force-pushed
the
mcbattirola/cluster-management
branch
from
a25a7f0 to
f77c193
Compare
…tirola/cluster-management
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.tsx
Outdated
Show resolved
Hide resolved
flyinghermit
approved these changes
Nov 1, 2024
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sakshyam Shah <[email protected]>
…tirola/cluster-management
ryanclark
reviewed
Nov 11, 2024
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.test.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Clusters/ManageCluster/ManageCluster.test.tsx
Outdated
Show resolved
Hide resolved
…onal/teleport into mcbattirola/cluster-management
…tirola/cluster-management
ryanclark
approved these changes
Nov 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
mcbattirola
added a commit
that referenced
this pull request
Dec 13, 2024
* (wip) manage clusters page * Route for non-root cluster * Minor adjustments * Missing license header * UI improvements * Add `isCloud` to cluster info * Initial loading state * Storybook, tests * Lint fix, godoc, etc * Unexport getClusterInfo response * rename `c` to clusterDetails * Inline `IsCloud` * Import order and useAsync * Remove unnecessary godoc * Apply suggestions from code review: add blank line Co-authored-by: Sakshyam Shah <[email protected]> * address code review comments: import order, JS docs * Use msw for testing * Assert error message before asserting that the version is not shown --------- Co-authored-by: Sakshyam Shah <[email protected]>
mcbattirola
added a commit
that referenced
this pull request
Dec 13, 2024
* (wip) manage clusters page * Route for non-root cluster * Minor adjustments * Missing license header * UI improvements * Add `isCloud` to cluster info * Initial loading state * Storybook, tests * Lint fix, godoc, etc * Unexport getClusterInfo response * rename `c` to clusterDetails * Inline `IsCloud` * Import order and useAsync * Remove unnecessary godoc * Apply suggestions from code review: add blank line Co-authored-by: Sakshyam Shah <[email protected]> * address code review comments: import order, JS docs * Use msw for testing * Assert error message before asserting that the version is not shown --------- Co-authored-by: Sakshyam Shah <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* (wip) manage clusters page * Route for non-root cluster * Minor adjustments * Missing license header * UI improvements * Add `isCloud` to cluster info * Initial loading state * Storybook, tests * Lint fix, godoc, etc * Unexport getClusterInfo response * rename `c` to clusterDetails * Inline `IsCloud` * Import order and useAsync * Remove unnecessary godoc * Apply suggestions from code review: add blank line * address code review comments: import order, JS docs * Use msw for testing * Assert error message before asserting that the version is not shown --------- Co-authored-by: Sakshyam Shah <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Add Cluster Management page (#47899) * (wip) manage clusters page * Route for non-root cluster * Minor adjustments * Missing license header * UI improvements * Add `isCloud` to cluster info * Initial loading state * Storybook, tests * Lint fix, godoc, etc * Unexport getClusterInfo response * rename `c` to clusterDetails * Inline `IsCloud` * Import order and useAsync * Remove unnecessary godoc * Apply suggestions from code review: add blank line Co-authored-by: Sakshyam Shah <[email protected]> * address code review comments: import order, JS docs * Use msw for testing * Assert error message before asserting that the version is not shown --------- Co-authored-by: Sakshyam Shah <[email protected]> * adapt to v16 --------- Co-authored-by: Sakshyam Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new page to manage clusters, which can be accessed through
Manage Clusters>Options>Manage Cluster.In the OSS version, this page only includes the cluster information. An enterprise PR will use this page and add additional information and inputs.
Note that this duplicates the information on the
Help & Supportpage. In a future PR, I'll remove this info from the Help page and this will be the only instance of it.I won't backport this until this page is finished, so having the information duplicated is fine for now. Once this information is removed from the help page, I'll also move the components to the cluster package.
Teleport.e PR: https://github.com/gravitational/teleport.e/pull/5231
I've exported the components to maximize how much we reuse between the OSS and Enterprise pages.
Designs: https://www.figma.com/design/v6GunK50D2VC7w7I2FBDNf/Access-(Management)?node-id=5532-138294&node-type=canvas&t=k857W5rJzig0zILk-0
Screenshots
changelog: Added Cluster Management page