Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Add Cluster Management page #50212

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mcbattirola
Copy link
Contributor

Backports #47899 to v17.

* (wip) manage clusters page

* Route for non-root cluster

* Minor adjustments

* Missing license header

* UI improvements

* Add `isCloud` to cluster info

* Initial loading state

* Storybook, tests

* Lint fix, godoc, etc

* Unexport getClusterInfo response

* rename `c` to clusterDetails

* Inline `IsCloud`

* Import order and useAsync

* Remove unnecessary godoc

* Apply suggestions from code review: add blank line

Co-authored-by: Sakshyam Shah <[email protected]>

* address code review comments: import order, JS docs

* Use msw for testing

* Assert error message before asserting that the version is not shown

---------

Co-authored-by: Sakshyam Shah <[email protected]>
@mcbattirola mcbattirola marked this pull request as ready for review December 13, 2024 15:39
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-50212.d212ksyjt6y4yg.amplifyapp.com

@mcbattirola mcbattirola changed the title [v17] Add Cluster Management page #47899 [v17] Add Cluster Management page Dec 13, 2024
@mcbattirola mcbattirola added the no-changelog Indicates that a PR does not require a changelog entry label Dec 20, 2024
@mcbattirola mcbattirola added this pull request to the merge queue Dec 20, 2024
Merged via the queue into branch/v17 with commit 91553da Dec 20, 2024
49 of 51 checks passed
@mcbattirola mcbattirola deleted the mcbattirola/v17/cluster-management branch December 20, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants