Reduce usages of go-cmp/cmp in production code #47290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/gocmp
branch
from
d8f563b to
d3b6f94
Compare
rosstimothy
added
backport/branch/v14
no-changelog
zmb3
approved these changes
Oct 8, 2024
GavinFrazar
approved these changes
Oct 8, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
|
@rosstimothy See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some comparisons using github.com/google/go-cmp/cmp in production code. The library is meant for tests and is liable to panic at any time.