migrate access request comparisons away from go-cmp

gravitational · Oct 7, 2024 · d8f563b · d8f563b
1 parent a6a0006
commit d8f563b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/api/types/access_request.go b/api/types/access_request.go
@@ -598,6 +598,11 @@ func (s AccessReview) GetAccessListTitle() string {
 	return s.AccessList.Title
 }
 
+// IsEqual t is equivalent to the provide AccessReviewThreshold.
+func (t *AccessReviewThreshold) IsEqual(o *AccessReviewThreshold) bool {
+	return deriveTeleportEqualAccessReviewThreshold(t, o)
+}
+
 // AccessRequestUpdate encompasses the parameters of a
 // SetAccessRequestState call.
 type AccessRequestUpdate struct {

diff --git a/api/types/derived.gen.go b/api/types/derived.gen.go
diff --git a/lib/services/access_request.go b/lib/services/access_request.go
@@ -26,7 +26,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-cmp/cmp"
 	"github.com/google/uuid"
 	"github.com/gravitational/trace"
 	"github.com/jonboulle/clockwork"
@@ -1630,7 +1629,7 @@ func (c *thresholdCollector) pushThreshold(t types.AccessReviewThreshold) (uint3
 
 	// don't bother double-storing equivalent thresholds
 	for i, threshold := range c.Thresholds {
-		if cmp.Equal(t, threshold) {
+		if t.IsEqual(&threshold) {
 			return uint32(i), nil
 		}
 	}