Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SSO MFA - Add SSO MFA ceremony #46982

Merged
merged 12 commits into from
Oct 29, 2024
Merged

feat: SSO MFA - Add SSO MFA ceremony #46982

merged 12 commits into from
Oct 29, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Sep 30, 2024

Part of the implementation of SSO MFA

Changelog: Support SSO as a second factor method in CLI clients (tsh and tctl). This is an opt-in feature.

Changes:

  • Add an optional SSO ceremony into the MFA ceremony to enable SSO MFA.
  • Implement SSO CLI prompt with the UX proposed in the RFD.

The Teleport Connect and WebUI implementations of the SSO MFA prompt will be added in follow up PRs.

Depends on #47684, #47874

@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch 2 times, most recently from 911d52a to b25ac07 Compare October 21, 2024 18:00
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony-base branch 2 times, most recently from 72266ca to 2fa3e72 Compare October 21, 2024 18:07
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch 2 times, most recently from 77c36a9 to 858bc3b Compare October 21, 2024 20:14
@Joerger Joerger changed the base branch from joerger/sso-mfa-ceremony-base to joerger/sso-mfa-challenge October 21, 2024 20:28
@Joerger Joerger force-pushed the joerger/sso-mfa-challenge branch from ce9dea5 to 60b4fe2 Compare October 22, 2024 21:27
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch 2 times, most recently from c594570 to 74c3706 Compare October 23, 2024 02:55
@Joerger Joerger changed the base branch from joerger/sso-mfa-challenge to joerger/sso-mfa-ceremony-base October 23, 2024 02:55
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch from 74c3706 to e784fb8 Compare October 23, 2024 03:18
@Joerger Joerger marked this pull request as ready for review October 23, 2024 03:41
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Oct 23, 2024
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch from cd3072f to 2952cbe Compare October 23, 2024 23:46
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony-base branch from 6954100 to 17bbb90 Compare October 23, 2024 23:46
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony-base branch from 17bbb90 to e9febd2 Compare October 24, 2024 18:51
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch 2 times, most recently from 2eef735 to 25ab5a7 Compare October 24, 2024 21:34
@Joerger Joerger changed the base branch from joerger/sso-mfa-ceremony-base to joerger/cli-prompt-refactor October 24, 2024 21:34
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch from 25ab5a7 to 93cbfdb Compare October 24, 2024 21:57
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch from 502c958 to 0f01e6e Compare October 29, 2024 17:55
@Joerger
Copy link
Contributor Author

Joerger commented Oct 29, 2024

@doggydogworld @kimlisa @rosstimothy Spooky ping to review 👻

@Joerger Joerger enabled auto-merge October 29, 2024 18:53
@Joerger Joerger added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@Joerger Joerger force-pushed the joerger/sso-mfa-ceremony branch from cc179e1 to 90fc543 Compare October 29, 2024 21:06
@Joerger Joerger enabled auto-merge October 29, 2024 21:06
@Joerger Joerger added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 5e7bdb2 Oct 29, 2024
40 checks passed
@Joerger Joerger deleted the joerger/sso-mfa-ceremony branch October 29, 2024 21:41
@public-teleport-github-review-bot

@Joerger See the table below for backport results.

Branch Result
branch/v17 Failed

@public-teleport-github-review-bot

@Joerger See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 size/md tctl tctl - Teleport admin tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants