feat: SSO MFA - WebUI backend implementation #47832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/sso-mfa-ceremony
branch
from
ada7cd8 to
c594570
Compare
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
3 times, most recently
from
7fe308a to
b122f9e
Compare
Joerger
force-pushed
the
joerger/sso-mfa-ceremony
branch
2 times, most recently
from
74c3706 to
e784fb8
Compare
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
b122f9e to
d5f2687
Compare
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
027a025 to
9eb8e61
Compare
Joerger
force-pushed
the
joerger/sso-mfa-ceremony
branch
7 times, most recently
from
6fb82a4 to
12c1da6
Compare
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
00c431b to
a45a867
Compare
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/sso-mfa-ceremony
branch
from
6cc7449 to
fb1c62e
Compare
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
a45a867 to
7947990
Compare
Joerger
force-pushed
the
joerger/sso-mfa-ceremony
branch
from
fb1c62e to
78d7977
Compare
|
@EdwardDowling @probakowski @rosstimothy Friendly ping to review |
probakowski
approved these changes
Nov 4, 2024
rosstimothy
approved these changes
Nov 4, 2024
|
|
||
| // SSOResponse is a json compatible [proto.SSOResponse]. | ||
| type SSOResponse struct { | ||
| RequestID string `json:"requestId,omitempty"` |
There was a problem hiding this comment.
It looks like the surrounding existing structs are using snake case
Suggested change
| RequestID string `json:"requestId,omitempty"` | |
| RequestID string `json:"request_id,omitempty"` |
There was a problem hiding this comment.
This is intentional, the frontend uses camel case, but we've been inconsistent with it on the backend.
There was a problem hiding this comment.
See a bit lower:
type AuthenticateWebUserRequest struct {
// User is a teleport username.
User string `json:"user"`
// WebauthnAssertionResponse is a signed WebAuthn credential assertion.
WebauthnAssertionResponse *wantypes.CredentialAssertionResponse `json:"webauthnAssertionResponse,omitempty"`
}
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
b1fa453 to
6f3674e
Compare
public-teleport-github-review-bot
bot
removed the request for review
from EdwardDowling
Joerger
force-pushed
the
joerger/sso-mfa-web
branch
from
5fe895b to
66bfc8e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Joerger
added a commit
that referenced
this pull request
Nov 6, 2024
* Add SSO MFA ceremony support to WebUI per-session MFA. * Add display name to SSO MFA device; Add SSO MFA device to SSO challenge. * Camel case json tags for front end. * Add sso channel ID for front end broadcast channel logic. * Fix backwards compatiblity issue; fix error message. * Fix test. * Fallback to connector id if display name isn't set. * Fix test. * Resolve comment. * Use uuid.NewRandom. * go mod tidy
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Add SSO MFA ceremony support to WebUI per-session MFA. * Add display name to SSO MFA device; Add SSO MFA device to SSO challenge. * Camel case json tags for front end. * Add sso channel ID for front end broadcast channel logic. * Fix backwards compatiblity issue; fix error message. * Fix test. * Fallback to connector id if display name isn't set. * Fix test. * Resolve comment. * Use uuid.NewRandom. * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the implementation of #44699
Add SSO MFA challenges and response to the web http api and websocket messages.
Depends on #46982
frontend implementation (per-session mfa only): #47876