Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SSO caveats on UserSpecV2.TrustedDeviceIDs #44847

Merged
merged 4 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/proto/teleport/legacy/types/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3490,6 +3490,13 @@ message UserSpecV2 {
LocalAuthSecrets LocalAuth = 9 [(gogoproto.jsontag) = "local_auth,omitempty"];

// TrustedDeviceIDs contains the IDs of trusted devices enrolled by the user.
//
// Note that SSO users are transient and thus may contain an empty
// TrustedDeviceIDs field, even though the user->device association exists
// under the Device Trust subsystem. Do not rely on this field to determine
// device associations or ownership, it exists for legacy/informative purposes
// only.
//
// Managed by the Device Trust subsystem, avoid manual edits.
repeated string TrustedDeviceIDs = 10 [(gogoproto.jsontag) = "trusted_device_ids,omitempty"];
}
Expand Down
7 changes: 7 additions & 0 deletions api/types/types.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,12 @@ spec:
type: object
trusted_device_ids:
description: TrustedDeviceIDs contains the IDs of trusted devices
enrolled by the user. Managed by the Device Trust subsystem, avoid
manual edits.
enrolled by the user. Note that SSO users are transient and thus
may contain an empty TrustedDeviceIDs field, even though the user->device
association exists under the Device Trust subsystem. Do not rely
on this field to determine device associations or ownership, it
exists for legacy/informative purposes only. Managed by the Device
Trust subsystem, avoid manual edits.
items:
type: string
nullable: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,12 @@ spec:
type: object
trusted_device_ids:
description: TrustedDeviceIDs contains the IDs of trusted devices
enrolled by the user. Managed by the Device Trust subsystem, avoid
manual edits.
enrolled by the user. Note that SSO users are transient and thus
may contain an empty TrustedDeviceIDs field, even though the user->device
association exists under the Device Trust subsystem. Do not rely
on this field to determine device associations or ownership, it
exists for legacy/informative purposes only. Managed by the Device
Trust subsystem, avoid manual edits.
items:
type: string
nullable: true
Expand Down
Loading