Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SSO caveats on UserSpecV2.TrustedDeviceIDs #44847

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

codingllama
Copy link
Contributor

Document that UserSpecV2.TrustedDeviceIDs may (and will!) disappear for SSO users.

The "correct" query is now under e/lib/devicetrust/storage.S.GetUserTrustedDeviceIDs.

#44598

@codingllama codingllama added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Jul 30, 2024
@github-actions github-actions bot requested review from camscale and nklaassen July 30, 2024 21:38
@codingllama codingllama requested a review from rosstimothy July 30, 2024 21:39
@codingllama
Copy link
Contributor Author

Adding a comment in the hopes that I (or someone else) doesn't trip on this again.

@codingllama codingllama enabled auto-merge July 30, 2024 21:40
@codingllama
Copy link
Contributor Author

Friendly ping @camscale @nklaassen ?

@codingllama codingllama added this pull request to the merge queue Jul 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 31, 2024
Copy link

github-actions bot commented Aug 1, 2024

🤖 Vercel preview here: https://docs-oroi5dow1-goteleport.vercel.app/docs/ver/preview

@codingllama codingllama added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 2966a67 Aug 1, 2024
42 checks passed
@codingllama codingllama deleted the codingllama/user-trusteddevices-comment branch August 1, 2024 21:28
@public-teleport-github-review-bot

@codingllama See the table below for backport results.

Branch Result
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants