Add pagerduty AMR integration #44754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
EdwardDowling
force-pushed
the
edwarddowling/pagerduty-amr
branch
from
5222085 to
fdeb10d
Compare
marcoandredinis
approved these changes
Aug 14, 2024
|
@tigrato can you take a look at this when you get a chance? |
r0mant
reviewed
Aug 16, 2024
integrations/access/pagerduty/app.go
Outdated
| func (a *App) getMessageRecipient(ctx context.Context, req types.AccessRequest) (string, error) { | ||
| recipientSetService := a.accessMonitoringRules.RecipientsFromAccessMonitoringRules(ctx, req) | ||
| if recipientSetService.Len() > 1 { | ||
| return "", trace.BadParameter("more than one service provided as PagerDuty plugin recipient") |
There was a problem hiding this comment.
Do we not support this? Can we just take the first one instead of hard-failing?
There was a problem hiding this comment.
Since these could be coming from separate rules with an undefined evaluation order taking the first would be pretty much just taking a random one which I doubt would be any users intent. I think failing to post anything would make more sense until we have the ability to set evaluation order for rules.
r0mant
reviewed
Aug 21, 2024
r0mant
approved these changes
Aug 27, 2024
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
tigrato
approved these changes
Aug 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@EdwardDowling See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial integration of Pagerduty plugin and Access Monitoring Rules routing
Depends on 43298 being merged first and will take this out of draft and update the description when it is.
changelog: Allow PagerDuty service used by plugin to be dynamically configured by creating Access Monitoring Rules resources with the required Pagerduty notify services.