Add initial AMR servicenow integration #44875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
EdwardDowling
force-pushed
the
edwarddowling/servicenow-amr
branch
from
4963ca7 to
94943b7
Compare
marcoandredinis
approved these changes
Aug 14, 2024
|
@tigrato can you take a look at this when you get a chance? |
r0mant
reviewed
Aug 20, 2024
There was a problem hiding this comment.
@EdwardDowling This and all other PRs that enable routing rules for plugins need test coverage before they can be approved/merged. E.g. #44754.
@r0mant Added tests for both PRs, can you take a look when you get a second? |
r0mant
approved these changes
Aug 27, 2024
tigrato
approved these changes
Aug 27, 2024
EdwardDowling
force-pushed
the
edwarddowling/servicenow-amr
branch
from
5c9833b to
1dc03e4
Compare
|
@EdwardDowling See the table below for backport results.
|
EdwardDowling
added a commit
that referenced
this pull request
Aug 28, 2024
* Add initial AMR servicenow integration * Update servicenow AMR integration to work with RuleHandler * Remove unused context * Remove unused handlerTimeout * Use watcher that allows confirming of allowed kinds * Add tests for servicenow amr interactions * Fix formating
EdwardDowling
added a commit
that referenced
this pull request
Aug 28, 2024
* Add initial AMR servicenow integration * Update servicenow AMR integration to work with RuleHandler * Remove unused context * Remove unused handlerTimeout * Use watcher that allows confirming of allowed kinds * Add tests for servicenow amr interactions * Fix formating
EdwardDowling
added a commit
that referenced
this pull request
Aug 30, 2024
* Add initial AMR servicenow integration * Update servicenow AMR integration to work with RuleHandler * Remove unused context * Remove unused handlerTimeout * Use watcher that allows confirming of allowed kinds * Add tests for servicenow amr interactions * Fix formating
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Add initial AMR servicenow integration * Update servicenow AMR integration to work with RuleHandler * Remove unused context * Remove unused handlerTimeout * Use watcher that allows confirming of allowed kinds * Add tests for servicenow amr interactions * Fix formating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial integration of ServiceNow plugin and Access Monitoring Rules routing
Depends on #43298 being merged first and will take this out of draft and update the description when it is.
changelog: Allow ServiceNow service used by plugin to be dynamically configured by creating Access Monitoring Rules resources with the desired ServiceNow assignee as the recipient.