Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc to v1.5.0 #44739

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

codingllama
Copy link
Contributor

Update protoc-gen-go-grpc to the latest version.

v1.5.0 introduces generic streaming interfaces like ClientStreamingClient and BidiStreamingClient. It also adds a "Unimplemented{Service}Server" panic check.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jul 29, 2024
@codingllama codingllama requested a review from rosstimothy July 29, 2024 14:04
@codingllama
Copy link
Contributor Author

codingllama commented Jul 29, 2024

We could disable the new streaming interfaces with use_generic_streams_experimental=false, but after a quick look they seem harmless enough to me.

I would not rely on them when coding for now, though.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rosstimothy July 29, 2024 14:12
@codingllama
Copy link
Contributor Author

FYI, fixed pointer embeds on 72c26f2.

@codingllama codingllama enabled auto-merge July 29, 2024 14:48
@codingllama codingllama added this pull request to the merge queue Jul 29, 2024
Merged via the queue into master with commit be520a3 Jul 29, 2024
41 checks passed
@codingllama codingllama deleted the codingllama/bump-grpc-gp branch July 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants