Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Fix various Unimplemented{Service}Server pointer embeds #44749

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

codingllama
Copy link
Contributor

Partial backport of #44739 to branch/v15.

Every non-initialized pointer embed is a potential future panic.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jul 29, 2024
@codingllama
Copy link
Contributor Author

This branch has a couple of unique occurrences. Others are clean.

@codingllama codingllama enabled auto-merge July 29, 2024 15:18
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from hugoShaka July 29, 2024 15:19
@codingllama codingllama added this pull request to the merge queue Jul 29, 2024
Merged via the queue into branch/v14 with commit 22631ef Jul 29, 2024
25 checks passed
@codingllama codingllama deleted the codingllama/grpc-unimpl-embed-v14 branch July 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants