Deflake TestSeekForward #42885
Merged
Deflake TestSeekForward #42885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
commented
Jun 12, 2024
zmb3
force-pushed
the
zmb3/test-seek-forward
branch
3 times, most recently
from
9169d3c to
c648da8
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
added
no-changelog
kimlisa
approved these changes
Jun 14, 2024
|
@nklaassen or @tcsc can I get another review? |
nklaassen
approved these changes
Jun 18, 2024
This test covers code paths that are highly dependent on time and difficult to test deterministically. The core functionality (ensuring that the delay is interrupted by seeking) is covered by TestSeekForwardTwice, so combine those two test cases into one.
zmb3
force-pushed
the
zmb3/test-seek-forward
branch
from
c648da8 to
1aec225
Compare
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.