Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Deflake TestSeekForward #43211

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jun 18, 2024

Backport #42885 to branch/v15

This test covers code paths that are highly dependent on time and
difficult to test deterministically. The core functionality
(ensuring that the delay is interrupted by seeking) is covered
by TestSeekForwardTwice, so combine those two test cases into one.
@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Jun 18, 2024
@github-actions github-actions bot requested review from kimlisa and nklaassen June 18, 2024 19:19
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from nklaassen June 20, 2024 10:50
@zmb3 zmb3 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into branch/v15 with commit dbb60fa Jun 20, 2024
32 of 33 checks passed
@zmb3 zmb3 deleted the bot/backport-42885-branch/v15 branch June 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants