[v14] Add conditional update methods for AccessList and AccessListMembers
#40318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atburke,
jakule,
mdwn,
rosstimothy,
smallinsky and
tcsc
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
tigrato
added
the
no-changelog
jakule
approved these changes
Apr 8, 2024
…s` (#40036) * Add conditional update methods for `AccessList` and `AccessListMembers` This PR adds two new methods for conditinally update an AccessList and AccessListMember resources to avoid overriding changed resources. This is a preparation for a ineligible status reconciler. Signed-off-by: Tiago Silva <[email protected]> * Update lib/services/simple/access_list.go Co-authored-by: rosstimothy <[email protected]> * handle review comments and drop copy methods * simplify code --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: rosstimothy <[email protected]>
tigrato
force-pushed
the
tigrato/backport-40036-b14
branch
from
b0d8bc0 to
56fc2fa
Compare
smallinsky
approved these changes
Apr 10, 2024
public-teleport-github-review-bot
bot
removed request for
mdwn,
tcsc,
atburke and
rosstimothy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40036 to branch/v14