Add conditional update methods for AccessList and `AccessListMember…

…s` (#40036)

* Add conditional update methods for `AccessList` and `AccessListMembers`

This PR adds two new methods for conditinally update an AccessList and
AccessListMember resources to avoid overriding changed resources.

This is a preparation for a ineligible status reconciler.

Signed-off-by: Tiago Silva <[email protected]>

* Update lib/services/simple/access_list.go

Co-authored-by: rosstimothy <[email protected]>

* handle review comments and drop copy methods

* simplify code

---------

Signed-off-by: Tiago Silva <[email protected]>
Co-authored-by: rosstimothy <[email protected]>

api/client/accesslist/accesslist.go

@@ -123,6 +123,18 @@ func (c *Client) UpsertAccessList(ctx context.Context, accessList *accesslist.Ac
 	return responseAccessList, trace.Wrap(err)
 }
 
+// UpdateAccessList updates an access list resource.
+func (c *Client) UpdateAccessList(ctx context.Context, accessList *accesslist.AccessList) (*accesslist.AccessList, error) {
+	resp, err := c.grpcClient.UpdateAccessList(ctx, &accesslistv1.UpdateAccessListRequest{
+		AccessList: conv.ToProto(accessList),
+	})
+	if err != nil {
+		return nil, trace.Wrap(err)
+	}
+	responseAccessList, err := conv.FromProto(resp)
+	return responseAccessList, trace.Wrap(err)
+}
+
 // DeleteAccessList removes the specified access list resource.
 func (c *Client) DeleteAccessList(ctx context.Context, name string) error {
 	_, err := c.grpcClient.DeleteAccessList(ctx, &accesslistv1.DeleteAccessListRequest{
@@ -219,6 +231,18 @@ func (c *Client) UpsertAccessListMember(ctx context.Context, member *accesslist.
 	return responseMember, trace.Wrap(err)
 }
 
+// UpdateAccessListMember updates an access list member resource using a conditional update.
+func (c *Client) UpdateAccessListMember(ctx context.Context, member *accesslist.AccessListMember) (*accesslist.AccessListMember, error) {
+	resp, err := c.grpcClient.UpdateAccessListMember(ctx, &accesslistv1.UpdateAccessListMemberRequest{
+		Member: conv.ToMemberProto(member),
+	})
+	if err != nil {
+		return nil, trace.Wrap(err)
+	}
+	responseMember, err := conv.FromMemberProto(resp)
+	return responseMember, trace.Wrap(err)
+}
+
 // DeleteAccessListMember hard deletes the specified access list member resource.
 func (c *Client) DeleteAccessListMember(ctx context.Context, accessList string, memberName string) error {
 	_, err := c.grpcClient.DeleteAccessListMember(ctx, &accesslistv1.DeleteAccessListMemberRequest{

api/proto/teleport/accesslist/v1/accesslist_service.proto

@@ -33,6 +33,8 @@ service AccessListService {
   rpc GetAccessList(GetAccessListRequest) returns (AccessList);
   // UpsertAccessList creates or updates an access list resource.
   rpc UpsertAccessList(UpsertAccessListRequest) returns (AccessList);
+  // UpdateAccessList updates an access list resource.
+  rpc UpdateAccessList(UpdateAccessListRequest) returns (AccessList);
   // DeleteAccessList hard deletes the specified access list resource.
   rpc DeleteAccessList(DeleteAccessListRequest) returns (google.protobuf.Empty);
   // DeleteAllAccessLists hard deletes all access lists.
@@ -53,6 +55,8 @@ service AccessListService {
   rpc GetAccessListMember(GetAccessListMemberRequest) returns (Member);
   // UpsertAccessListMember creates or updates an access list member resource.
   rpc UpsertAccessListMember(UpsertAccessListMemberRequest) returns (Member);
+  // UpdateAccessListMember conditionally updates an access list member resource.
+  rpc UpdateAccessListMember(UpdateAccessListMemberRequest) returns (Member);
   // DeleteAccessListMember hard deletes the specified access list member
   // resource.
   rpc DeleteAccessListMember(DeleteAccessListMemberRequest) returns (google.protobuf.Empty);
@@ -125,6 +129,12 @@ message UpsertAccessListRequest {
   AccessList access_list = 1;
 }
 
+// UpdateAccessListRequest is the request for updating an access list.
+message UpdateAccessListRequest {
+  // access_list is the access list to upsert.
+  AccessList access_list = 1;
+}
+
 // DeleteAccessListRequest is the request for deleting an access list.
 message DeleteAccessListRequest {
   // name is the name of the access list to delete.
@@ -237,6 +247,13 @@ message UpsertAccessListMemberRequest {
   Member member = 4;
 }
 
+// UpdateAccessListMemberRequest is the request for updating an access list
+// member.
+message UpdateAccessListMemberRequest {
+  // member is the access list member to upsert.
+  Member member = 1;
+}
+
 // DeleteAccessListMemberRequest is the request for deleting a member from an
 // access list.
 message DeleteAccessListMemberRequest {