Replace isTeam with new flags
#39794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alan Parra <[email protected]>
…move-team--use-new-flags
…tirola/remove-team--use-new-flags
…ravitational/teleport into mcbattirola/remove-team--use-new-flags
mcbattirola
force-pushed
the
mcbattirola/remove-team--use-new-flags
branch
from
e2a217d to
5701cbd
Compare
mcbattirola
force-pushed
the
mcbattirola/remove-team--use-new-flags
branch
from
5701cbd to
2bde5a4
Compare
Co-authored-by: Michelle Bergquist <[email protected]>
mcbattirola
force-pushed
the
mcbattirola/remove-team--use-new-flags
branch
from
5e385d4 to
380bff8
Compare
kimlisa
reviewed
Apr 25, 2024
web/packages/teleport/src/Sessions/__snapshots__/Sessions.story.test.tsx.snap
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Support/__snapshots__/Support.story.test.tsx.snap
Outdated
Show resolved
Hide resolved
ryanclark
approved these changes
Apr 29, 2024
michellescripts
approved these changes
Apr 29, 2024
Co-authored-by: Michelle Bergquist <[email protected]>
kimlisa
approved these changes
Apr 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mcbattirola
added a commit
that referenced
this pull request
May 6, 2024
* Add new flags to modules * Add deprecated comments to isTeam * Make support flag an enum * Add a TODO instead of deprecating flag right away Co-authored-by: Alan Parra <[email protected]> * Add gogoproto.jsontag to new fields * remove meaning from enum zero value * Reuse proto.SupportType instead of suping * Replace isTeam for new flags in web app * Update proto file: rename enum 0 value to unspecified;fix json tag casing * Reuse proto file instead of aliasing it * undo removing method by accident * Add MobileDeviceManagement field to web config struct * Improve comments * Fix tests * Simplify lockedFeatures object * Include JoinActiveSessions in the web config object * Remove more instances of isTeam * Apply suggestions from code review - improve comments Co-authored-by: Michelle Bergquist <[email protected]> * Use consistent comments to remove isTeam * Update godocs comments * Revert removign `isTeam` from stories it still should * Fix godoc typo Co-authored-by: Michelle Bergquist <[email protected]> --------- Co-authored-by: Alan Parra <[email protected]> Co-authored-by: Michelle Bergquist <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Add new flags to modules * Add deprecated comments to isTeam * Make support flag an enum * Add a TODO instead of deprecating flag right away * Add gogoproto.jsontag to new fields * remove meaning from enum zero value * Reuse proto.SupportType instead of suping * Replace isTeam for new flags in web app * Update proto file: rename enum 0 value to unspecified;fix json tag casing * Reuse proto file instead of aliasing it * undo removing method by accident * Add MobileDeviceManagement field to web config struct * Improve comments * Fix tests * Simplify lockedFeatures object * Include JoinActiveSessions in the web config object * Remove more instances of isTeam * Apply suggestions from code review - improve comments * Use consistent comments to remove isTeam * Update godocs comments * Revert removign `isTeam` from stories it still should * Fix godoc typo --------- Co-authored-by: Alan Parra <[email protected]> Co-authored-by: Michelle Bergquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker: https://github.com/gravitational/cloud/pull/8611 being released
This PR removes the usage of
isTeam, replacing it by a flag that represents each feature.isTeamwas used to enable/disable multiple features. Now, we're going to have one flag per feature instead of relying on the product.These flags were introduced in #39695 and are already being sent by Cloud's API to Teleport
The translation table is:
The only
isTeamusage left is to determine a marketing URL. This will require coordination with the marketing team to determine how to handle it. I've added aTODOon it and will fix in the future.I've also removed the fields from
lockedFeaturesthat were simple proxies from other properties and used those properties directly instead. Only kept inlockedFeaturesvalues that require a more complex calculation than simplyfeature: !cfg.feature.teleport.ePR: https://github.com/gravitational/teleport.e/pull/3781More info can be found in https://github.com/gravitational/cloud/issues/8067
Contributes to https://github.com/gravitational/cloud/issues/8067