[v15] Replace isTeam with new flags
#41217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new flags to modules * Add deprecated comments to isTeam * Make support flag an enum * Add a TODO instead of deprecating flag right away Co-authored-by: Alan Parra <[email protected]> * Add gogoproto.jsontag to new fields * remove meaning from enum zero value * Reuse proto.SupportType instead of suping * Replace isTeam for new flags in web app * Update proto file: rename enum 0 value to unspecified;fix json tag casing * Reuse proto file instead of aliasing it * undo removing method by accident * Add MobileDeviceManagement field to web config struct * Improve comments * Fix tests * Simplify lockedFeatures object * Include JoinActiveSessions in the web config object * Remove more instances of isTeam * Apply suggestions from code review - improve comments Co-authored-by: Michelle Bergquist <[email protected]> * Use consistent comments to remove isTeam * Update godocs comments * Revert removign `isTeam` from stories it still should * Fix godoc typo Co-authored-by: Michelle Bergquist <[email protected]> --------- Co-authored-by: Alan Parra <[email protected]> Co-authored-by: Michelle Bergquist <[email protected]>
mcbattirola
added
the
no-changelog
zmb3
changed the title
isTeam with new flags (#39794)isTeam with new flags
kimlisa
approved these changes
May 6, 2024
marcoandredinis
approved these changes
May 13, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark and
michellescripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #39794 to v15