Init discover resources inside the discover component #39166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
added
the
no-changelog
zmb3
approved these changes
Mar 10, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
avatus
added a commit
that referenced
this pull request
Mar 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Prevent code splitting (#38706) This will prevent the react bundle from being code split. This means that our entire javascript bundle will be a single file as well as our css file. It also removes hashing from the included webassets. The reason for this change is to allow different versioned proxies to coexist behind a load balancer. If we remove code splitting, then the only time our bundle will load is on initial hit, and the web client will then have the entire bundle. This also removes React.lazy. React.lazy wrapped components in a promise to allow for dynamic imports during runtime. This is no longer needed. Lastly, to clean up the default exports used by react lazy, this removes (most) default exports for feature components. Assist and telemetry-boot are not included in the javascript bundle * Fix the import on the account settings page (#39015) * Fix auth connector imports (#39019) * Init discover resources inside the discover component (#39166) * Use ETag headers for served javascript files (#39251) --------- Co-authored-by: Bartosz Leper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39163
This PR will make the
RESOURCESvalue initialized inside the component. Before, it was initialized at a global level which would get a falsy value forcfg.isEnterprise.I checked around to see other global instances of
cfgused and didn't find any (yet) but I'll still keep looking around. So far, it seems most references are held within functions which is good since none of them are called until after the app is initialized.This PR fixes the issue above, but if any other instances of a global cfg use pop up, i'll open a separate PR with all of them