Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Consolidate webasset bundle to single chunks #39198

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Mar 11, 2024

Backport #38706, #39019, #39015, #39166, #39251

This backport handles he large chunk of consolidating the webasset chunks initial PR as well as the subsequent fixes that went out.

avatus and others added 4 commits March 11, 2024 11:02
This will prevent the react bundle from being code split. This means
that our entire javascript bundle will be a single file as well as our
css file. It also removes hashing from the included webassets. The reason
for this change is to allow different versioned proxies to coexist behind a
load balancer. If we remove code splitting, then the only time our bundle
will load is on initial hit, and the web client will then have the entire
bundle.

This also removes React.lazy. React.lazy wrapped components in a promise
to allow for dynamic imports during runtime. This is no longer needed.

Lastly, to clean up the default exports used by react lazy, this removes
(most) default exports for feature components. Assist and telemetry-boot
are not included in the javascript bundle
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Mar 11, 2024
@avatus
Copy link
Contributor Author

avatus commented Mar 21, 2024

This is waiting to be merged until right before 15.2

@avatus avatus added this pull request to the merge queue Mar 27, 2024
Merged via the queue into branch/v15 with commit d0b8382 Mar 27, 2024
38 of 39 checks passed
@avatus avatus deleted the avatus/v15/backport-38706 branch March 27, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants