-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saml_idp_service_provider
label and label expression to RoleConditions
#39039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckAndSetDefault test
…/saml_idp_service_provider_labels
flyinghermit
changed the title
Role label and label expression for
Add Mar 6, 2024
saml_idp_service_provider
resourcesaml_idp_service_provider
label and label expression to RoleConditions
flyinghermit
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Mar 6, 2024
Note to reviewer: |
mdwn
approved these changes
Mar 6, 2024
tigrato
approved these changes
Mar 7, 2024
tigrato
approved these changes
Mar 7, 2024
mdwn
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds label and label expression types for
saml_idp_service_provider
resource in theRoleConditions
and adds them to label matchers.TODO and followups:
Note: no default wildcard label values are assigned to
saml_idp_service_provider_labels
. I think that's a safe default and we no longer add such wildcard value forapps
,nodes
,database
,kubernetes
resource sinceRole v4
.