Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove saml_idp_service_provider_labels and saml_idp_service_provider_labels_expression #40047

Merged
merged 4 commits into from
Mar 29, 2024
Merged

remove saml_idp_service_provider_labels and saml_idp_service_provider_labels_expression #40047

merged 4 commits into from
Mar 29, 2024

Conversation

flyinghermit
Copy link
Contributor

Reverts #39039

@flyinghermit flyinghermit marked this pull request as ready for review March 29, 2024 20:18
@flyinghermit flyinghermit added the no-changelog Indicates that a PR does not require a changelog entry label Mar 29, 2024
@flyinghermit flyinghermit requested review from r0mant and mdwn and removed request for marcoandredinis and tigrato March 29, 2024 20:19
@flyinghermit
Copy link
Contributor Author

Thank you for quick review folks 🙏

@flyinghermit flyinghermit added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit bdba1a6 Mar 29, 2024
43 of 44 checks passed
@flyinghermit flyinghermit deleted the sshah/remove-saml-idp-service-provider-labels branch March 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrato tigrato tigrato approved these changes

@mdwn mdwn mdwn approved these changes

@r0mant r0mant r0mant approved these changes

Assignees
No one assigned
Labels
helm no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flyinghermit @r0mant @mdwn @tigrato