build: Generate centos7 archive when building linux-amd64 #38415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camscale
added
the
no-changelog
probakowski
approved these changes
Feb 20, 2024
tcsc
reviewed
Feb 22, 2024
tcsc
approved these changes
Feb 22, 2024
public-teleport-github-review-bot
bot
removed request for
wadells,
r0mant,
fheinecke and
rudream
fheinecke
approved these changes
Feb 22, 2024
camscale
force-pushed
the
camh/gen-centos7-archive
branch
from
3c96d06 to
d329b94
Compare
When building a linux-amd64 archive, make a copy of it with the `centos7` tag as the linux-amd64 build works on centos7. We stopped doing a centos7-specific build a while ago, but we still have the archive on our releases page. This helps unify the `release-amd64` and `release-amd64-centos7` targets, which currently do the same thing except for the GitHub Actions workflow that creates the centos7 archive only for the latter target. This will allow us to get rid of that target as that latter target will no longer be called when Drone is removed. Also add a `-p` when making RELEASE_DIR as sometimes the parent directory has not yet been created.
* chore: Use golangci-lint version from versions.mk * gravitational/teleport.e#3488 * Fix Access Monitoring prebuild query * gravitational/teleport.e#3482 * ci: Switch tag build workflows to artifact@v4 GHA action * gravitational/teleport.e#3510 * ci: Fix RPM build with release-amd64{,-fips} targets * gravitational/teleport.e#3500
camscale
force-pushed
the
camh/gen-centos7-archive
branch
from
d329b94 to
ff04d97
Compare
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a linux-amd64 archive, make a copy of it with the
centos7tag as the linux-amd64 build works on centos7. We stoppeddoing a centos7-specific build a while ago, but we still have the
archive on our releases page.
This helps unify the
release-amd64andrelease-amd64-centos7targets, which currently do the same thing except for the GitHub Actions
workflow that creates the centos7 archive only for the latter target.
This will allow us to get rid of that target as that latter target will
no longer be called when Drone is removed.
Also add a
-pwhen making RELEASE_DIR as sometimes the parentdirectory has not yet been created.
Update
eref.Companion: https://github.com/gravitational/teleport.e/pull/3500
Issue: #20729
Test-run: https://github.com/gravitational/teleport.e/actions/runs/7970766106
Test-run: https://github.com/gravitational/teleport.e/actions/runs/7971816767