[v15] Add tag build support to Makefile #38661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camscale
added
the
no-changelog
camscale
force-pushed
the
camh/v15/backport-tag-build
branch
from
14b9749 to
6db0216
Compare
tigrato
approved these changes
Feb 27, 2024
fheinecke
approved these changes
Feb 27, 2024
public-teleport-github-review-bot
bot
removed request for
wadells,
r0mant,
tcsc and
probakowski
wadells
approved these changes
Feb 27, 2024
When building a linux-amd64 archive, make a copy of it with the `centos7` tag as the linux-amd64 build works on centos7. We stopped doing a centos7-specific build a while ago, but we still have the archive on our releases page. This helps unify the `release-amd64` and `release-amd64-centos7` targets, which currently do the same thing except for the GitHub Actions workflow that creates the centos7 archive only for the latter target. This will allow us to get rid of that target as that latter target will no longer be called when Drone is removed. Also add a `-p` when making RELEASE_DIR as sometimes the parent directory has not yet been created.
Add a `tag-publish` recipe to the Makefile to start a workflow run of the tag-publish workflow. The tag published is the current version tag as defined by `$(VERSION)` in the Makefile. The version of the `tag-publish` workflow used is that one tagged with `v$(VERSION)`.
Add a `tag-build` recipe to the Makefile to kick off a tag build on GitHub Actions. Currently we cannot trigger the tag build in GitHub Actions as the teleport repository is public so we are very careful with credentials in it, and credentials are needed to run the `tag-build` workflow in the `teleport.e` repository. The new process for building a tag is to run `make update-tag` as usual, but to then follow that with `make tag-build` to start the build.
Updates include: * Make the access list gRPC service use the cache. (gravitational/teleport.e#3544) * Prevent overflow in sort functions provided to slices.SortFunc (#gravitational/teleport.e3549) * Remove all quiet/silent flags from role checks. (#gravitational/teleport.e3540) * [v15] fix: Lower bcrypt cost when testing (#gravitational/teleport.e3553) * [v15] Add top-level workflow for building a tagged release (#gravitational/teleport.e3547)
camscale
force-pushed
the
camh/v15/backport-tag-build
branch
from
6db0216 to
884f943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport teleport PRs that update the
Makefilefor tag build support:tag-publishrecipe to Makefile #38475)tag-buildrecipe to Makefile #38481)The backports were trival with no conflicts.
Companion: https://github.com/gravitational/teleport.e/pull/3547
Backport: #38415
Backport: #38475
Backport: #38481
Issue: #20729
Issue: #20732
Test-run: https://github.com/gravitational/teleport.e/actions/runs/8058311677
Test-run: https://github.com/gravitational/teleport.e/actions/runs/8060536475
This PR will not be merged until after the companion PR has been merged,
at which point an
eref update commit will be added to this PR topoint at that merged PR.