Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add preset field to SAMLIdPServiceProviderV1 spec #37968

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

flyinghermit
Copy link
Contributor

@flyinghermit flyinghermit commented Feb 8, 2024

The preset field will be used to process custom configuration for specified service provider. The field can be empty in default state (which means a generic service provider type) but if a value is provided, we expect to be one of the supported one.

kind: saml_idp_service_provider
metadata:
  name: appname
spec:
  preset: gcp (or azure, gitlab etc)
  entity_id: https://samlsp-host

A new package samlsp has been added that defines a preset name for GCP. Subsequent name for other SAML apps, including their custom configuration values (if any) will go into this package.

changelog: The saml_idp_service_provider spec adds a new preset field that can be used to specify pre-built SAML service provider profile.

Copy link

github-actions bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of comments

api/types/saml_idp_service_provider.go Outdated Show resolved Hide resolved
api/types/saml_idp_service_provider.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Feb 8, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

github-actions bot commented Feb 8, 2024

The PR changelog entry failed validation: The changelog entry must start with a letter.

@flyinghermit flyinghermit added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@flyinghermit flyinghermit added this pull request to the merge queue Feb 9, 2024
Merged via the queue into master with commit 0cc7731 Feb 9, 2024
37 checks passed
@flyinghermit flyinghermit deleted the sshah/samlidp-preset-profile branch February 9, 2024 14:54
@public-teleport-github-review-bot

@flyinghermit See the table below for backport results.

Branch Result
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants