-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add preset field to SAMLIdPServiceProviderV1
spec
#37968
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple of comments
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: The changelog entry must start with a letter. |
@flyinghermit See the table below for backport results.
|
The
preset
field will be used to process custom configuration for specified service provider. The field can be empty in default state (which means a generic service provider type) but if a value is provided, we expect to be one of the supported one.A new package
samlsp
has been added that defines a preset name for GCP. Subsequent name for other SAML apps, including their custom configuration values (if any) will go into this package.changelog: The
saml_idp_service_provider
spec adds a newpreset
field that can be used to specify pre-built SAML service provider profile.