[v15] add preset field to SAMLIdPServiceProviderV1 spec #39277
Merged
+1,677
−1,562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
changed the title
|
Manual backport. |
espadolini
approved these changes
Mar 13, 2024
|
|
||
| // validatePreset validates SAMLIdPServiceProviderV1 preset field. | ||
| // preset can be either empty or one of the supported type. | ||
| func validatePreset(preset string) bool { |
There was a problem hiding this comment.
This PR is not the place to change this, but if you happen to touch this part of the codebase in the future it might be cleaner to move validatePreset to the samlsp package IMO.
camscale
approved these changes
Mar 13, 2024
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #37968 and #39151 (updates the former PR) to Branch/v15
changelog: The
saml_idp_service_providerspec adds a newpresetfield that can be used to specify predefined SAML service provider profile.