This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Update Braintree creds for test #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verbose log in #4615. |
Closed
chadwhitacre
force-pushed
the
selenium-workaround
branch
from
31c0469 to
f25adf6
Compare
chadwhitacre
force-pushed
the
update-braintree-creds
branch
from
8d8c072 to
0a7213e
Compare
This was referenced Sep 10, 2017
|
Hmm ... probs w/ |
|
Alright, so what's it doing there? |
|
Two of the tests are trying to add calls to the cassette.
|
chadwhitacre
force-pushed
the
update-braintree-creds
branch
from
0a7213e to
89b2b04
Compare
For whatever reason they are different now when I browse to find them in the sandbox admin. This also folds back to one set of creds for both dev and test. We split test in 6d8b0a1 but I'm not sure why (convenience at the time?).
Ahead of rerecording them using new API creds.
Redoes all of TestPages, including non-Braintree calls.
chadwhitacre
force-pushed
the
update-braintree-creds
branch
from
89b2b04 to
dc3a378
Compare
|
Rebased on master post-#4614 and base changed, waiting for Travis ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
← #4614 — #4598 →
I need to add a custom field to our Braintree sandbox account as part of #4613, but I don't have access to do that. In the interest of time, here is a PR that rerecords all of our Braintree fixture against an account that I have access to.
master