Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

👊 👊 🍖 #4615

Closed
chadwhitacre opened this issue Sep 10, 2017 · 73 comments
Closed

👊 👊 🍖 #4615

chadwhitacre opened this issue Sep 10, 2017 · 73 comments

Comments

@chadwhitacre
Copy link
Contributor

Trying to get commits from #4613 into some kind of usable review pipeline. I'm in a mess with Braintree remote API creds during testing and VCR (re)recording.
@chadwhitacre
Copy link
Contributor Author

We have two sets of creds, one in defaults.env, the other in tests/defaults.env (added in 6d8b0a1, I think just for convenience).

@chadwhitacre
Copy link
Contributor Author

VCR cassettes intermingle Braintree API calls with all of the other API calls, so if we want to rerecord all of the Braintree APIs then its work to do that without rerecording the other API calls. I mean, we rerecord whenever we CI master at Travis and that appears to be green so it should work, right?

@chadwhitacre
Copy link
Contributor Author

The problem I'm hitting is that the account represented by the creds currently in tests/defaults.env doesn't have the custom field I need in order to record these new API calls against it.

@chadwhitacre
Copy link
Contributor Author

Why does it not work to rerecord existing tests against a new Braintree account?

@chadwhitacre
Copy link
Contributor Author

Oooh! Was there some special casing for BillingHarness? A need to run that in a special way by itself or something?

@chadwhitacre
Copy link
Contributor Author 

$ gs
 D tests/py/fixtures/BillingHarness.yml
 D tests/py/fixtures/ConsumeChangeStreamTests.yml
 D tests/py/fixtures/TestElsewhere.yml
 D tests/py/fixtures/TestFriendFinder.yml
 D tests/py/fixtures/TestHistory.yml
 D tests/py/fixtures/TestNMassPays.yml
 D tests/py/fixtures/TestNewTeams.yml
 D tests/py/fixtures/TestPages.yml
 D tests/py/fixtures/TestPayday.yml
 D tests/py/fixtures/TestPayin.yml
 D tests/py/fixtures/TestRoutes.yml
 D tests/py/fixtures/TestTeamEdit.yml
 D tests/py/fixtures/TestTeams.yml
 D tests/py/fixtures/TestsWithBillingHarness.yml
$

@chadwhitacre
Copy link
Contributor Author

Ah! Need the old custom_field, ya?

@chadwhitacre
Copy link
Contributor Author

Appears that way ...

(Pdb) result
<ErrorResult 'Custom field is invalid: participant_id.' at 10ce54890>
(Pdb)

... but ...

screen shot 2017-09-09 at 8 20 25 pm

🤔

@chadwhitacre
Copy link
Contributor Author

Am I hitting the right account?

@chadwhitacre
Copy link
Contributor Author

I went to check production to see how it's set there. I guess I typed the password wrong because I got "Your account is now locked out. Please wait 30 minutes and try again." For one bad password attempt? 😳

@chadwhitacre
Copy link
Contributor Author

False alarm! gratipay vs. gratipay_

@chadwhitacre
Copy link
Contributor Author

Production

screen shot 2017-09-09 at 8 24 08 pm

@chadwhitacre
Copy link
Contributor Author

Sandbox

screen shot 2017-09-09 at 8 24 34 pm

@chadwhitacre
Copy link
Contributor Author

Oh! Need to re-record. 😊

@chadwhitacre
Copy link
Contributor Author 

(Pdb) result
<SuccessfulResult {customer: <Customer {first_name: None, last_name: None, id: u'[]'} at []>} at []>
(Pdb)

💃

@chadwhitacre
Copy link
Contributor Author

Okay! How many tests does that fix? 😁

@chadwhitacre
Copy link
Contributor Author

Gah! Now hitting 'Gateway Rejected: duplicate', something I saw on #4613 and reported to Braintree support—don't expect that from sandbox requests.

@chadwhitacre
Copy link
Contributor Author

Workaround over there is purge sandbox (takes a few minutes).

@chadwhitacre
Copy link
Contributor Author

(And, helpfully, doesn't whack custom fields. 👍 )

@chadwhitacre
Copy link
Contributor Author

(I've logged out of production. Better not go back in there tonight except hopefully to set the custom field!)

@chadwhitacre
Copy link
Contributor Author

Aaaaaand of course my wireless interface died again. 🐭 Happened a couple days ago, too. Getting worse. Had to reboot several times and actually power down and back up. Skin of our teeth, @gratipay!

@chadwhitacre
Copy link
Contributor Author

Yeah, okay, back to these duplicates. :-/

I guess let's purge the sandbox and try again?

@chadwhitacre
Copy link
Contributor Author

/me kicks that off ...

@chadwhitacre
Copy link
Contributor Author

Okay, I'm back in. Rerunning ...

@chadwhitacre
Copy link
Contributor Author

Skunked.

================================================== FAILURES ==================================================
_______________________________ TestsWithBillingHarness.test_capch_full_amount _______________________________
Traceback (most recent call last):
  File "/Users/whit537/personal/gratipay/gratipay.com/tests/py/test_billing_exchanges.py", line 115, in test_capch_full_amount
    assert error == ''  # sanity check
AssertionError: assert 'Gateway Rejected: duplicate' == ''
  - Gateway Rejected: duplicate
-------------------------------------------- Captured stdout call --------------------------------------------
pid-768 thread-140736820274112 (MainThread) Holding 2091 cents ($20.00 + $0.91 fee = $20.91) on Braintree for obama ... failed: Gateway Rejected: duplicate
_____________________________ TestsWithBillingHarness.test_capch_partial_amount ______________________________
Traceback (most recent call last):
  File "/Users/whit537/personal/gratipay/gratipay.com/tests/py/test_billing_exchanges.py", line 126, in test_capch_partial_amount
    assert error == ''  # sanity check
AssertionError: assert 'Gateway Rejected: duplicate' == ''
  - Gateway Rejected: duplicate
-------------------------------------------- Captured stdout call --------------------------------------------
pid-768 thread-140736820274112 (MainThread) Holding 2091 cents ($20.00 + $0.91 fee = $20.91) on Braintree for obama ... failed: Gateway Rejected: duplicate
_____________________________ TestsWithBillingHarness.test_capch_too_high_amount _____________________________
Traceback (most recent call last):
  File "/Users/whit537/personal/gratipay/gratipay.com/tests/py/test_billing_exchanges.py", line 134, in test_capch_too_high_amount
    assert error == ''  # sanity check
AssertionError: assert 'Gateway Rejected: duplicate' == ''
  - Gateway Rejected: duplicate
-------------------------------------------- Captured stdout call --------------------------------------------
pid-768 thread-140736820274112 (MainThread) Holding 2091 cents ($20.00 + $0.91 fee = $20.91) on Braintree for obama ... failed: Gateway Rejected: duplicate
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! KeyboardInterrupt !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
/usr/local/Cellar/python/2.7.13_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/ssl.py:653: KeyboardInterrupt

@chadwhitacre
Copy link
Contributor Author

YES!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 💃

screen shot 2017-09-09 at 8 55 29 pm

@chadwhitacre
Copy link
Contributor Author 

tests/py/fixtures/BillingHarness.yml
6:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/customers
28:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/customers
50:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/payment_methods

tests/py/fixtures/TestsWithBillingHarness.yml
8:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
50:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/awtzjbc6/submit_for_settlement
93:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/awtzjbc6/void
138:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
180:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/fpjm0ep0/submit_for_settlement
222:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/fpjm0ep0
264:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/fpjm0ep0/void
309:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
351:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/59fd1wvd/submit_for_settlement
394:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/59fd1wvd/void
439:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
481:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/a371g057/submit_for_settlement
525:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/a371g057/void
567:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/customers
589:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/payment_methods
621:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
664:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/customers
686:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/payment_methods
716:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/payment_methods
748:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
790:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/res21cek/void
834:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
876:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/7mpag0w8/void
920:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
962:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/3mjm48sd/submit_for_settlement
1006:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
1048:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/h85kc7fw/submit_for_settlement
1093:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
1135:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/d81x0fd1/submit_for_settlement
1180:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions
1222:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/2typ1xje/submit_for_settlement
1265:    uri: https://api.sandbox.braintreegateway.com:443/merchants/bk8h97tqzyqjhtfn/transactions/advanced_search_ids

@chadwhitacre
Copy link
Contributor Author

Oh. 😁

$ gs
 M tests/py/fixtures/BillingHarness.yml
 D tests/py/fixtures/ConsumeChangeStreamTests.yml
 D tests/py/fixtures/TestElsewhere.yml
 D tests/py/fixtures/TestFriendFinder.yml
 D tests/py/fixtures/TestHistory.yml
 D tests/py/fixtures/TestNMassPays.yml
 D tests/py/fixtures/TestNewTeams.yml
 D tests/py/fixtures/TestPages.yml
 D tests/py/fixtures/TestPayday.yml
 D tests/py/fixtures/TestPayin.yml
 D tests/py/fixtures/TestRoutes.yml
 D tests/py/fixtures/TestTeamEdit.yml
 D tests/py/fixtures/TestTeams.yml
 M tests/py/fixtures/TestsWithBillingHarness.yml
$

@chadwhitacre
Copy link
Contributor Author 

tests/py/fixtures/BillingHarness.yml
6:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
28:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
50:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods

tests/py/fixtures/TestHistory.yml
8:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
49:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/6tvkry/submit_for_settlement
93:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
134:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/4w92rd/submit_for_settlement
176:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids

tests/py/fixtures/TestNMassPays.yml
8:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
50:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/k0tqp8ks/submit_for_settlement
94:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
136:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/e733859z/submit_for_settlement
180:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
222:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/1dygf0mg/submit_for_settlement
264:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids

tests/py/fixtures/TestPages.yml
6:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
28:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
128:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
150:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
250:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/cj4ztr
280:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/cj4ztr
310:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/33477840
344:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/client_token
380:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
402:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
502:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/gxny4r
532:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/gxny4r
562:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/12743055
596:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/client_token

tests/py/fixtures/TestPayday.yml
8:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
49:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/c9xhq4/submit_for_settlement
93:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
134:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/k5q4rt/submit_for_settlement
178:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
219:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/d2dqbt/submit_for_settlement
263:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
304:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/38r9r8/submit_for_settlement
346:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids

tests/py/fixtures/TestPayin.yml
6:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids
27:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
68:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/bthrmy/void
110:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/bthrmy
154:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
195:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids
216:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search
259:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids
280:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search
323:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/8vx7md/void

tests/py/fixtures/TestRoutes.yml
7:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
42:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/35060504
81:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/9yg226
99:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/35060504
125:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
148:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/bkhpqm
178:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/11443524
212:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/client_token
248:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
271:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/client_token
307:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/bkhpqm
337:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers/11443524
371:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/client_token
407:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods/any/bkhpqm
437:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids

tests/py/fixtures/TestsWithBillingHarness.yml
8:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
50:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/gasm2aq5/submit_for_settlement
93:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/gasm2aq5/void
138:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
180:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/hy1g7153/submit_for_settlement
222:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/hy1g7153
264:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/hy1g7153/void
309:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
351:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/dcjbnhzk/submit_for_settlement
394:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/dcjbnhzk/void
439:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
481:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/bsafgvhn/submit_for_settlement
525:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/bsafgvhn/void
567:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
589:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
621:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
664:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/customers
686:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
716:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/payment_methods
748:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
790:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/722684ny/void
834:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
876:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/b25wkwrs/void
920:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
962:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/mnn5g3cd/submit_for_settlement
1006:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
1048:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/8fw0kke8/submit_for_settlement
1092:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
1134:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/0fmkw38j/submit_for_settlement
1178:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions
1220:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/2wge34xf/submit_for_settlement
1262:    uri: https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions/advanced_search_ids

@chadwhitacre
Copy link
Contributor Author

Eight out of 14 fixture files have Braintree API calls in them.

@chadwhitacre
Copy link
Contributor Author

on_the_fence is failing early in browse when we try to pre-pop the receipt page.

new_participant is failing in routes/credit-card.spt.

@chadwhitacre
Copy link
Contributor Author

Hmm ... each fails locally when run individually ... both on routes/credit-card.spt 🤔

@chadwhitacre
Copy link
Contributor Author

Run together the two fail as at Travis.

$ ARGS="tests/py/test_pages.py" t

@chadwhitacre
Copy link
Contributor Author

Seems easy enough to record and add, but why didn't they get added in the first big re-record?

@chadwhitacre
Copy link
Contributor Author

Re-run of all of tests/py/ fails in the same way.

@chadwhitacre chadwhitacre changed the title Sort out hairiness with Braintree remote API in testing 👊 👊 🍖 Sep 10, 2017
@chadwhitacre
Copy link
Contributor Author

Repurposing this ticket to be my verbose log for shipping #4598 in the next ... three hours?

@chadwhitacre
Copy link
Contributor Author

Will see if #4616 runs green, then rebase the chain.

@chadwhitacre
Copy link
Contributor Author

Reviewing work to be done ...

@chadwhitacre
Copy link
Contributor Author

Okay! #4616 is green! I'm going to merge #4614 and #4616, and then rebase the #4598 chain.

@chadwhitacre
Copy link
Contributor Author

Done. Almost done organizing tickets ...

@chadwhitacre
Copy link
Contributor Author

Alright, so that's four more PRs needed against #4598:

  • error checking
  • optional
  • receipt
  • ToS

Okay! 👊 👊 🍖

@chadwhitacre
Copy link
Contributor Author

Debating whether to self-review-and-merge the four ready PRs on #4598 or start into new work and then review/merge all eight at once. Eight sounds like a lot, thinking let's get these four in now.

@chadwhitacre
Copy link
Contributor Author

I mean, Travis will take half an hour to run anyway.

@chadwhitacre
Copy link
Contributor Author

Which actually raises a good point: optimization is to merge the last in the chain that is ready to merge, to avoid the rebase-and-wait-for-Travis dance overhead.

@chadwhitacre
Copy link
Contributor Author

Re: dance overhead: https://www.youtube.com/watch?v=ovo6zwv6DX4.

@chadwhitacre
Copy link
Contributor Author

Alright, 4-chain updated, go Travis go! I know there are a couple things to fix on #4617, what about the others?

@chadwhitacre
Copy link
Contributor Author

#4606 is fine, #4604 is what #4617 exists to fix. Knocking out #4617 issues ...

@chadwhitacre
Copy link
Contributor Author

#4606 is green but #4604 ain't. What gives?

@chadwhitacre
Copy link
Contributor Author

Probably will need to bump #4609 back off in the interest of time.

@chadwhitacre
Copy link
Contributor Author

Errors, receipt, terms. Next chain!

@chadwhitacre
Copy link
Contributor Author

Sup with #4604 tho?

@chadwhitacre
Copy link
Contributor Author

Okay, fixed.

I can do a simpler optional rationalization (no folding, just the two sections) on #4613.

@chadwhitacre
Copy link
Contributor Author

#4604 is green, almost have #4617 ready.

@chadwhitacre
Copy link
Contributor Author

Alright, #4617 over to Travis, hitting #4613.

@chadwhitacre
Copy link
Contributor Author

#4617 is green! I am modifying/extending functionality on #4613.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Sep 10, 2017 •
edited
Loading

slack:

I am hoping to finish #4621 while traveling.
Then I can do #4611 together w/ @jdorfman.
The ToS update is going to be so small.
And that’s about it for #4598!

@chadwhitacre
Copy link
Contributor Author

Alright, squeezing out last little bit of CI floofle on #4621 and then the new three-chain is ready for final review and merge. 👍

@chadwhitacre
Copy link
Contributor Author

Landed #4598!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadwhitacre