Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Implement JSON endpoint for homepage form #4604

Closed
wants to merge 1 commit into from

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Sep 7, 2017

#4606#4613

Todo

@chadwhitacre chadwhitacre changed the title Stub out the ecosystem chooser Wire up the homepage form Sep 7, 2017
@chadwhitacre chadwhitacre mentioned this pull request Sep 7, 2017
10 tasks
@chadwhitacre
Copy link
Contributor Author

From slack (edit not picked up in archive):

Alright, if we want any chance of getting this out by Sunday, then I think what we do is:

  1. Merge and deploy Support queueing emails without participants #4548.
  2. Charge immediately and mail a receipt. No verification step whatsoever.
  3. We only allow anon to fill in the form. Auth redirects to /browse/projects(!).

@chadwhitacre
Copy link
Contributor Author

Todo here simplified per above.

@chadwhitacre chadwhitacre mentioned this pull request Sep 8, 2017
4 tasks
@chadwhitacre chadwhitacre changed the base branch from new-homepage to new-homepage-plumbing September 8, 2017 00:51
@chadwhitacre chadwhitacre force-pushed the new-homepage-wireup branch 4 times, most recently from 681c6ff to 26daf1d Compare September 8, 2017 15:54
@chadwhitacre chadwhitacre force-pushed the new-homepage-wireup branch 5 times, most recently from 41dfd1a to d74e14c Compare September 8, 2017 21:59
@chadwhitacre
Copy link
Contributor Author

Okay! Ready for review here. Line ∆ is high due to fixtures.

@chadwhitacre chadwhitacre changed the title Wire up the homepage form Implement JSON endpoint for homepage form Sep 8, 2017
@chadwhitacre
Copy link
Contributor Author

Hmm ... interesting Travis failure in test_history.py -k iter_payday_events ... unrelated file. Not present on master.

@chadwhitacre
Copy link
Contributor Author

But it does fail in isolation on this branch.

@chadwhitacre
Copy link
Contributor Author

Failure seemingly introduced on bc37e3e. 🤔

@chadwhitacre
Copy link
Contributor Author

Or not? 😞

@chadwhitacre
Copy link
Contributor Author

Alright, I left the body in there. If this is the only test that's failing then maybe we should go back to that after all?

@chadwhitacre
Copy link
Contributor Author

Referring to:

match_on = ['url', 'method', 'body'],

@chadwhitacre
Copy link
Contributor Author

We took that out back in #2588.

@chadwhitacre
Copy link
Contributor Author

Alright, didn't work instantly, so taking body back out of match and sticking with the two-class hack.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Sep 10, 2017

Rebased, was 982f75c 403e7cb.

@chadwhitacre
Copy link
Contributor Author

Sup Travis?

@chadwhitacre
Copy link
Contributor Author

lol cassettes 😆

@chadwhitacre
Copy link
Contributor Author

Rerecorded, was 1f10b7b.

Clean up JSON endpoint for homepage form
@chadwhitacre chadwhitacre changed the base branch from new-homepage-plumbing to new-homepage-api-cleanups September 10, 2017 16:55
@chadwhitacre chadwhitacre changed the base branch from new-homepage-api-cleanups to new-homepage September 10, 2017 17:00
@chadwhitacre
Copy link
Contributor Author

Merged under #4613.

@chadwhitacre chadwhitacre deleted the new-homepage-wireup branch September 10, 2017 17:01
@chadwhitacre
Copy link
Contributor Author

🚨 Self-merge license 🚨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant