Return payday charges for finance reconciliation

[kaguillera]

This is an return of daily payday charges for the financial reconciliation checking. It is different from the original by also breaking down by money processing vendors.

[kaguillera]

Stupid question @whit537 do I have to do tests for this page?

[kaguillera]

NB this is blocking gratipay/finances#2 among other PRs

[kaguillera]

oh @whit537 please review

[chadwhitacre]

I would say invert this since it's not a part of a page (as before) but the entire page.

if not user.ADMIN:
    raise Response(401 if user.ANON else 403)

[kaguillera]

fair enough will do

[chadwhitacre]

Test failures?

[kaguillera]

Yep not sure why, going to work on that today. I only changed one line 😦

[kaguillera]

I rebase so I don't know why it is saying out-of-date. ready for review @whit537 et al.

[mattbk]

I pushed the button, no actual changes.

[mattbk]

This all looks good to me.

[chadwhitacre]

Rebased, was 22adf42.

[chadwhitacre]

@kaguillera and I are going through this together looking at gratipay/finances#6.

[chadwhitacre]

Alright, this is some kinda messed up. We are now rewriting this dashboard based on the needs for gratipay/finances#6. Basically we want to show all exchanges grouped in several ways (maybe we can do that client-side?). But now we are seeing old, old exchanges with braintree-cc for network, where we would expect Stripe, and there is no stripe-cc in the database:

gratipay::MAROON=> \dT+ payment_net
                                       List of data types
┌────────┬─────────────┬───────────────┬──────┬──────────────┬───────────────────┬─────────────┐
│ Schema │    Name     │ Internal name │ Size │   Elements   │ Access privileges │ Description │
├────────┼─────────────┼───────────────┼──────┼──────────────┼───────────────────┼─────────────┤
│ public │ payment_net │ payment_net   │ 4    │ balanced-ba ↵│                   │             │
│        │             │               │      │ balanced-cc ↵│                   │             │
│        │             │               │      │ paypal      ↵│                   │             │
│        │             │               │      │ bitcoin     ↵│                   │             │
│        │             │               │      │ braintree-cc↵│                   │             │
│        │             │               │      │ cash        ↵│                   │             │
│        │             │               │      │ transferwise↵│                   │             │
│        │             │               │      │ dwolla      ↵│                   │             │
│        │             │               │      │ unknown      │                   │             │
└────────┴─────────────┴───────────────┴──────┴──────────────┴───────────────────┴─────────────┘
(1 row)

gratipay::MAROON=>

Fortunately, while @kaguillera was blocking on this PR he went ahead and wrote a script that uses our payday logs to aggregate values, which led us to the realization that we have good data in there for #3912 … which is the 🐰 🕳️ that we are staring down once again. It's soooooooooo far down. 😩

[chadwhitacre]

This is blocked on #3912, yes? Closing since who knows when we will land that. 😞