Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Include team members in MassPay #4111

Merged
merged 7 commits into from
Sep 1, 2016
Merged

Include team members in MassPay #4111

merged 7 commits into from
Sep 1, 2016

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Aug 24, 2016 •
edited
Loading

⬑ #3994

← #4113 (diff)

TODO

This was referenced Aug 24, 2016
Merged
Closed
@chadwhitacre
Copy link
Contributor Author

Hmm ... this test is failing at Travis (even after a restart) but not locally.

@chadwhitacre
Copy link
Contributor Author

A clue! Picard's balance is 0; locally it's 100.

@chadwhitacre
Copy link
Contributor Author

Hunch: it's something to do with a network call during payday.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Aug 24, 2016 •
edited
Loading

Yeah, looks like we're hung up on a VCR call. Hmm ...

@chadwhitacre
Copy link
Contributor Author

Why does that fail at Travis but not locally?

@chadwhitacre
Copy link
Contributor Author

Suuuuuure looks like there's a <Request (POST) https://api.sandbox.braintreegateway.com:443/merchants/j9gwdfjdkxymhdgr/transactions> ...

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Aug 24, 2016 •
edited
Loading

Here's one with the right amount. Maybe the participant_id is off?

@chadwhitacre
Copy link
Contributor Author

Well, it's 2 on Travis, and it's 4 in that cassette, but it's also 2 locally. Hmm ...

@chadwhitacre
Copy link
Contributor Author

Time to bring out the HTTP debug helper! 🙀

@chadwhitacre
Copy link
Contributor Author

Dorp. Constraining to just the one test fixed it! Hmm ...

@chadwhitacre
Copy link
Contributor Author

Alright, here's output from e9db11c ... let's compare ...

@chadwhitacre
Copy link
Contributor Author

Looks like it's a bleedthrough from another test. Trying to narrow it down ...

@chadwhitacre
Copy link
Contributor Author

Gosh, now we're getting weird different errors.

@chadwhitacre
Copy link
Contributor Author

Alright, this is a mess. 😞

More later!

@chadwhitacre
Copy link
Contributor Author

This morning it is looking like I just needed to regenerate the relevant test fixture. Let's see if Travis is happy with 59dd4ee (i.e., only one failing test instead of two).

@chadwhitacre
Copy link
Contributor Author

Yesssss. Travis looks good for 8f3a751.

@chadwhitacre
Copy link
Contributor Author

Ready for review! (Includes #4102.)

@chadwhitacre chadwhitacre mentioned this pull request Aug 25, 2016
Merged
1 task
@chadwhitacre
Copy link
Contributor Author

I split out some noisy testing refactors into #4113.

@rohitpaulk rohitpaulk self-assigned this Aug 29, 2016
@chadwhitacre
Copy link
Contributor Author

Rebased on master post-#4113. Previous head was 4fc4ac6.

@chadwhitacre
Copy link
Contributor Author

pay out even after leaving a team—#4111 (comment)
only pay out w/ verified identity—#4111 (comment)

I'm working on these.

@chadwhitacre chadwhitacre force-pushed the takes-masspay branch 3 times, most recently from 172df1d to 51663f5 Compare September 1, 2016 14:22
@chadwhitacre
Copy link
Contributor Author

I'm debugging a weird interaction amongst the new tests.

@chadwhitacre
Copy link
Contributor Author

@kaguillera and I are making some progress on this. "I wouldn't exactly call it progress." —@kaguillera

@chadwhitacre
Copy link
Contributor Author

Okay! Three commits coming ... one to clean up our test fixture, another to add failing tests for the two issues, and then the fixes.

@chadwhitacre
Copy link
Contributor Author

Maybe ... 😩

@chadwhitacre
Copy link
Contributor Author

... !

@chadwhitacre
Copy link
Contributor Author

Dangit! We're back to square one with afc0ec4: four failing tests instead of two. We may give this one more shot before punting MassPay to next week. 😞

@chadwhitacre chadwhitacre force-pushed the takes-masspay branch 2 times, most recently from 50c663d to 1085a96 Compare September 1, 2016 18:43
@chadwhitacre chadwhitacre mentioned this pull request Sep 1, 2016
Closed
@chadwhitacre
Copy link
Contributor Author

Alright, we think the problem is simply that we weren't updating the necessary test fixture for the new failing tests.

@chadwhitacre
Copy link
Contributor Author

@rohitpaulk You (or anyone else?) around to review this so we can merge and run with this today? If not @kaguillera and I may proceed anyway, since you already gave it one pass ...

@chadwhitacre
Copy link
Contributor Author

Okay! Done working on this, ready for review if it's available. :-)

@chadwhitacre
Copy link
Contributor Author

GREEEEEEEEEEEEEEEEEEEENNNNNNNNNN!!!!!!!!

🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀
🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀 🍀

@chadwhitacre
Copy link
Contributor Author

@kaguillera and I are gonna give this another 30 minutes before merging and proceeding with MassPay on gratipay/inside.gratipay.com#800 ...

@chadwhitacre
Copy link
Contributor Author

Okay! Going for it! :rage4:

@chadwhitacre chadwhitacre merged commit 4b5b0b3 into master Sep 1, 2016
@chadwhitacre chadwhitacre deleted the takes-masspay branch September 1, 2016 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rohitpaulk rohitpaulk

Labels
Review
Projects
None yet
Milestone
Bring Back Take-What-You-Want for Tea...
Development

Successfully merging this pull request may close these issues.
2 participants
@chadwhitacre @rohitpaulk