Bring back takes for Team Gratipay #3994
Comments
|
Alright, I've laid out a plan in the description. We're off and running! 💃 |
|
@kaguillera and I are planning to work on this today. |
|
@aandis You around to help with review? I anticipate that we're gonna spit out a bunch of PRs today. 💃 |
|
|
|
Sorry, I am caught up with my college exams for a week. 😞 Will be here after that. |
No worries, I thought that might be the case. Do well on your exams! ⚾️ 🔋 |
|
As I'm working through #4005 on my way to UI for storing and modifying participant identities, I'm really feeling like we want to keep a lid on this. I think we want to throttle who we accept identity information from, because it's highly likely that we'll need to make changes to this system as we start to gain real-world experience with it. The more people who have entered their identity info, the more friction we'll have against changes. Security researchers will surely hit it (which we want), but it'll be hard to sort out researchers from non-researchers. We could discard data for researchers, but that looks amateur if we discard real users' data. I think at the very least we should avoid putting the identity form in the nav. That should prevent most folks from finding it and therefore filling it out. A step further would be to put a nonce in front of it so that only people with a unique link could access it—i.e., people we invite (nonces would be single-use and tied to participants). |
|
Basically, once we have a few identities in there, the next step down this path will be to start exploring programmatic identity verification (#2449) in earnest. That's a big undertaking for us, and I will be very surprised if we don't need to reenter identity info based on whatever system we end up implementing. But! #2449 is step 4.i on our product roadmap/priorities ... and we're still on step 1. As deep as my head is in thinking about payroll right now while working on this ticket, I want to remember that the plan is to set this all aside once we've got payroll back for Team Gratipay. We aren't going to get back to generalizing payroll until after we've a) finished cleaning up after the Gratipocalypse, and b) hit payments out of the park. Realistically we're looking at 2017, given that we also have other Radars besides Product to keep up with—Tech and Accounting loom large, per "Making it Right," as well as Security. Which is all to say that I think we should limit entering of identity information to just those of us who are going to be on Team Gratipay itself. It's probably enough to keep it out of the nav. Anyone who finds the form by reading our source code should probably be on the Team anyway. :-) |
... or reading this thread. 😚 |
|
next steps:
|
|
ttfn |
|
Worked through the timeline for this over bad 🍻 with @hurlothrumbo. Basically, we need to front-load the work. Step next is merging #3998. It's appropriate to pause for a bit of review before landing that, since it's the heart of our crypto implementation. I think it would be best for @rohitpaulk or possibly @aandis to merge that one once we're ready, given its weighty nature. Step N+1 is to slam out the rest of the work, which at this point looks like will mostly fall on my shoulders to do—but! I need a reviewer to help me keep the pipeline flowing. @kaguillera and I are expecting to cowork on Wednesday and Thursday as usual (yes?). My goal is to get as many PRs as possible lined up before Wednesday noon, sooo ... Wednesday and Thursday @kaguillera and I can work through the review queue. That said, I'm not going to hesitate to keep the PRs moving, with or without @kaguillera. We need to get this done! On Friday we'll come up for air. I'll have to put in time for COS. It's also Mother's Day weekend over here. But, basically whatever is left to do, I'll do. My goal is to have all of the code deployed by Sunday night. That gives us Monday through Wednesday to shake out the bugs and sign us all up! Thursday we run payroll for the first time since the Gratipocalypse ... and then we celebrate! Who's ready? You can help by reviewing PRs before and as they come up, also rebasing downstream ones as we land the one on deck. Let's do this! |
... and of course by taking the PR on deck, reviewing, merging, and deploying it! |
Welllllllllll ... crunch. Email notice from Sentry:
The |
|
Hmmm ... there's no schema enforced, I guess we can use Gratipay's EIN as a tax id, right? :) |
>>> from gratipay import wireup
>>> wireup.db(wireup.env())
<gratipay.models.GratipayDB object at 0x7f0388866950>
>>> from gratipay.models.participant import Participant
>>> from gratipay.models.country import Country
>>> US = Country.from_code('US')
>>> Participant.from_id(20176).set_identity_verification(US.id, True)
>>> |
|
AAAAAAAHHHHHHHHHH!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 🙀 📎 ⚡ 🐦
|
|
AAAAAAAHHHHHHHHHH!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 🙀 📎 ⚡ 🐦
|
|
Holy buckets!
|
Done in #800! |
@mattbk @rohitpaulk Are you seeing a Team Gratipay distribution in your PayPal account? |
|
|
|
@mattbk Yes! How about in PayPal, though? 😁 |
|
|
|
There it is. We're done! 😌 |
|
So good to see this again
|
This is the main ticket for the "Bring Back Take-What-You-Want for Team Gratipay" milestone.
Done
This ticket/milestone is done when we successfully distribute Gratipay Team revenue to ~users as part of payday. The
sixfive ~users we are targeting for the first distribution are:@kaguillera@rohitpaulk @mattbk @aandis @clone1018 @whit537.Steps
National Identity
add schema and Python for countries #3999→ Add countries #4027implement encrypted national identities #4000→ Encrypted identities #4028add schema and Python for [un]verifying identities #4001→ add schema and Python for [un]verifying identities #4031implement clearing identities #4002→ implement clearing identities #4032implement has_verified_identity #4003→ implement has_verified_identity #4033implement UI for working with national identities #4008→ Identity form #4034Takes
_mixin_team.py: Migrate takes plumbing to 2.0 #4074review computed values algorithms→ reticketed review computed values algorithms #4120review docs for new mixins→ reticketed review docs for new mixins #4121fill out the test suite for the mixins, prune old tests→ reticketed fill out the test suite for the mixins, prune old tests #4122Finish!
availablefor Team GratipayThe text was updated successfully, but these errors were encountered: