Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Update tests for new mixins #4127

Merged
merged 4 commits into from
Nov 22, 2016
Merged

Update tests for new mixins #4127

merged 4 commits into from
Nov 22, 2016

Conversation

chadwhitacre
Copy link
Contributor

Closes #4122.

@chadwhitacre
Copy link
Contributor Author

Testing with (e.g.):

[gratipay] $ envtest tests/py/test_team_membership.py --cov gratipay.models.team.mixins.membership --cov-report=annotate

@chadwhitacre chadwhitacre mentioned this pull request Sep 22, 2016
Closed
@chadwhitacre
Copy link
Contributor Author

I don't know what tests I thought we should prune. Ready for review!

@chadwhitacre
Copy link
Contributor Author

Rebased on master. Previous head was a10aa3d.

@aandis @rohitpaulk This is a fairly straightfoward holdover from #3994. Could we review and get this in before proceeding with #4148?

@chadwhitacre
Copy link
Contributor Author

Bump for review. Previous head was 9cd08fd.

@chadwhitacre chadwhitacre mentioned this pull request Nov 21, 2016
Closed
@chadwhitacre
Copy link
Contributor Author

Wanna review this one, @kaguillera? :-)

@kaguillera
Copy link
Contributor

LGTM

@chadwhitacre
Remove unused method
13b33a6 
I think the plan was to use this in closing teams? We can bring it back
when we get to #3602, I guess.
@chadwhitacre
Round out tests for membership mixin
f1bafcd 
This surfaced a bug in get_memberships (yay!), a holdover from when
Teams were a special kind of Participant rather than a separate entity.
@chadwhitacre
Update get_take_last_week_for
df5c9be 
Brings the API into alignment with get_take_for and adds a test suite.
@chadwhitacre
Add tests for vetting during set_take_for
346dac7
@chadwhitacre
Copy link
Contributor Author

Rebased! Previous head was b38072e.

@kaguillera You know what to do ... ;-)

@kaguillera
Copy link
Contributor

Travis is taking really long...waiting for green to merge.

@chadwhitacre
Copy link
Contributor Author

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

Restarting!

@kaguillera
Copy link
Contributor

umh this is awkward... @whit537 😕

@kaguillera kaguillera merged commit 41339f8 into master Nov 22, 2016
@kaguillera kaguillera deleted the mixin-test-coverage branch November 22, 2016 17:20
@chadwhitacre
Copy link
Contributor Author

?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadwhitacre @kaguillera