This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Bring back the payouts UI behind a flag #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
added this to the Bring Back Take-What-You-Want for Team Gratipay milestone
This was referenced Jul 1, 2016
chadwhitacre
force-pushed
the
available
branch
2 times, most recently
from
cb834fc to
d0466c7
Compare
This works around a bug in Sphinx where the print function under Python 2.7 prevents class attributes from showing up in documentation. I want to be able to document some attributes on the Team class.
This gives us more control. Rarely is alphabetical order the right sort order.
Conflicts: sql/branch.sql
The page is broken, but that's okay because no-one will see it until we set available.
| def test_distributing_doesnt_redirect_when_money_is_available(self): | ||
| self.make_team() | ||
| self.db.run("UPDATE teams SET available=537") | ||
| assert self.client.GET('/TheEnterprise/distributing/', raise_immediately=False).code == 500 |
There was a problem hiding this comment.
It's a 500 that no user would've hit, since it's behind a flag (available) which no Team has the power to set themselves—making this PR deployable while also keeping it reasonably sized. However, this PR landed on master together with the next one (#4073), which includes a fix for the 500 (17b9bd3). Now, #4073 also introduces a test for another 500, which is still on master. Again, my thinking is that deploying broken code behind the available flag allows us to keep chipping away with manageable PRs instead of batching up until everything is "perfect." You okay with that?
There was a problem hiding this comment.
Aha! Yes, that is fine :)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬑ #3994
← #4070 (diff) — #4073 →
See #3994 (comment).