Encrypted identities

[chadwhitacre]

⬑ #3994

⬑ #3976
#4001 →

Punchlist

• require a valid email before saving—implement encrypted national identities #4000 (comment)
• clear identities in Participant.clear_personal_information
• add rekeying—implement encrypted national identities #4000 (comment)
• use cursor in add_event
• remake against master once add schema and Python for countries #3999 lands
• deal with identities during take_over

[chadwhitacre]

Thinking through take_over ...

[chadwhitacre]

Hmmm ... build failed but it looks like an old commit; restarting at Travis.

[chadwhitacre]

Given that ~alice is taking over ~bob, the options are:

1. ~alice gets ~bob's identities.
2. ~alice gets ~bob's verified identities but not ~bob's unverified ones.
3. We drop ~bob's identities.
4. We block the take_over until ~bob drop's their own identities.

For cases (1) and (2) we'd have to prompt ~alice to choose if both ~bob and ~alice have an identity for a given country. For (3) we'd have to warn the user (~alice).

[chadwhitacre]

@kaguillera suggests (1) with reverification for verified identities.

[chadwhitacre]

Travis is still failing. The commit is c6b1dfe, a merge commit of 7f2666c into 1308454.

[chadwhitacre]

Huh. During the initial rebase for this PR, we fixed these tests that are now failing. Hmmm ...

[chadwhitacre]

Now they're failing again locally, investigating ...

[chadwhitacre]

Ah, okay. There was a merge conflict in the first commit during the rebase, so the rebase stopped and in the cleanup process we happened to fix the relevant tests on that commit. However, subsequent commits that did not introduce rebase conflicts did introduce new, now-bad tests. We didn't catch those because we didn't test at every step. Re-rebasing ...

[chadwhitacre]

C'mon, Travis! No whammies!

[chadwhitacre]

Yesssssssssss.

[chadwhitacre]

Alright, back to take over (#4028 (comment)) ...

We're thinking that for today we should simply error out if the secondary (other) participant has an identity. We'll have to be smarter when we expand takes beyond Gratipay (and perhaps before), but for now this should be okay.

[chadwhitacre]

Alright, naive implementation of take_over protection in df1f985. We can improve later. If anyone triggers this in the near future, they're messing around.

[chadwhitacre]

Alright, we're down to it here. This is the one PR in the chain that I wish we could get more review on, since it's larger and is where we actually use the crypto we added in #3998.

@rohitpaulk @aandis Perhaps you could take a look at this one after the fact? I want to get takes online for tomorrow or I'd hold this up further. 😶

[chadwhitacre]

Aaaaaannnnddd ..........

[chadwhitacre]

"Ready?"
"Merge."