Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

preen layout #3749

Merged
merged 10 commits into from
Sep 7, 2015
Merged

preen layout #3749

merged 10 commits into from
Sep 7, 2015

Conversation

chadwhitacre
Copy link
Contributor

Gonna leave this one sit a few days. We need to stop having me merge my own pull requests!

Ping @mattbk @rohitpaulk @techtonik @kzisme @kaguillera @clone1018 et al.

Who wants to merge this one? :-)

@chadwhitacre
Copy link
Contributor Author

Closes #3739, while also fixing a bunch of other little things.

screen shot 2015-09-02 at 11 02 22 pm

@chadwhitacre
Copy link
Contributor Author

Tested on OS X in Chrome, Safari, and Firefox:

screen shot 2015-09-02 at 11 16 18 pm

@chadwhitacre chadwhitacre mentioned this pull request Sep 3, 2015
@chadwhitacre chadwhitacre force-pushed the preen-layout branch 3 times, most recently from 29a2902 to 318e5e8 Compare September 3, 2015 04:51
@chadwhitacre
Copy link
Contributor Author

screen shot 2015-09-03 at 12 59 03 am

@techtonik
Copy link
Contributor

@whit537 it is hard to review, because it is not really clear what was there before. And this gives me an idea - what if we add site screens to repository, so that every PR with design changes has a visual annotation of changes?

https://help.github.com/articles/rendering-and-diffing-images/

@chadwhitacre
Copy link
Contributor Author

[I]t is not really clear what was there before.

Just look at https://gratipay.com/, no?

@chadwhitacre
Copy link
Contributor Author

And this gives me an idea - what if we add site screens to repository, so that every PR with design changes has a visual annotation of changes?

This is an interesting idea. I think we'd want to automate it to prevent it from becoming unwieldy—there are so many app states to consider that the number of screenshots involved would be quite large.

@chadwhitacre chadwhitacre modified the milestone: Pivot Sep 7, 2015
@chadwhitacre
Copy link
Contributor Author

Rebased on master.

chadwhitacre added a commit that referenced this pull request Sep 7, 2015
@chadwhitacre chadwhitacre merged commit b575535 into master Sep 7, 2015
@chadwhitacre chadwhitacre deleted the preen-layout branch September 7, 2015 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants