add status icons to Team explorer

[chadwhitacre]

red, yellow, green for rejected, under review, and approved

See GitHub Issues open/closed icons for inspiration.

Reticketed from #3704.

[chadwhitacre]

Done in #3749.

[mattbk]

Icons overlap text in Chrome for Windows.

[chadwhitacre]

Interesting! I don't see that behavior in Chrome on Mac OS:

It's probably because we're depending on a font for those (they're Unicode characters) and the fonts differ between Windows and Mac OS.

[mattbk]

It starts by loading the image below, then switches to what I posted previously when the page is done loading. Windows Chrome. Is it loading emoji first, and then images?

[chadwhitacre]

The colored images are actually still emoji, but my hunch is it's starting with a default font and then upgrading to another font. We should probably just use images instead of emoji for consistency.

[mattbk]

Oops, this is a local problem. I use the plugin "Emoji Input by EmojiStuff.com" to add emoji. When I turn it off, the icons show up as in my most recent image. That explains the delay when loading.

[chadwhitacre]

Ah, okay. But #3739 (comment) is still bad, right?

[mattbk]

Yes, but I'm not sure how common that would be. I don't know how many different emoji fonts there are.

[chadwhitacre]

Right, so for consistency's sake I think we should use the same icon font method we're using for the sign-in icons and the footer icons.

[chadwhitacre]

I've deployed #3765. How do the status icons look now, @mattbk?

[chadwhitacre]

Here's what I see: