This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!m @Changaco ! |
Changaco
force-pushed
the
i18n-statements
branch
2 times, most recently
from
December 14, 2014 17:51
06a06b3
to
51a9ec6
Compare
Rebased on master. |
Changaco
force-pushed
the
i18n-statements
branch
from
December 14, 2014 18:42
51a9ec6
to
cd28906
Compare
Changaco
force-pushed
the
i18n-statements
branch
from
December 19, 2014 12:19
cd28906
to
ab3dfd3
Compare
Changaco
force-pushed
the
i18n-statements
branch
from
December 19, 2014 23:03
ab3dfd3
to
4869372
Compare
Changaco
force-pushed
the
i18n-statements
branch
from
December 19, 2014 23:10
4869372
to
b3866d9
Compare
Testing this out, getting the following error on my profile page. I made clean and tried a fresh checkout. What do you recommend?
|
@clone1018 - Did you apply |
Yeah I did |
Weird, seems to work fine on my side. |
@clone1018 Good catch, I've fixed the bug. |
Looks good at first blush, digging deeper ... |
WHERE statement <> '' | ||
AND number = 'plural'; | ||
|
||
CREATE FUNCTION enumerate(anyarray) RETURNS TABLE (rank bigint, value anyelement) AS $$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I'd also like to call them Organizations instead of Teams but for now I guess this is the nomenclature we're using.
All issues I've had have been fixed, I'd like to get this merged but I'm not sure where you stand on it @whit537 |
Woo, thanks @Changaco ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2669 and closes #1659. Also refactors and cleans up a lot of stuff, including some of the JS code.